Nip\Router\Middleware\RouteResolverMiddleware

Complexity

Total Complexity

9

Size/Duplication

Total Lines	67
Duplicated Lines	28.36 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

38.46%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	process()	0	10	2
A	getRouter()	0	4	1
A	populateRequest()	19	19	5

<?php

namespace Nip\Router\Middleware;

use Nip\Http\ServerMiddleware\Middlewares\ServerMiddlewareInterface;
use Nip\Request;
use Nip\Router\RequestContext;
use Nip\Router\Router;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\RequestHandlerInterface;

/**
 * Class StartSession
 * @package Nip\Session\Middleware
 */
class RouteResolverMiddleware implements ServerMiddlewareInterface
{

    /**
     * The session manager.
     *
     * @var Router
     */
    protected $router;

    /**
     * Create a new session middleware.
     *
     * @param Router $router
     */
    public function __construct(Router $router)
    {
        $this->router = $router;
    }

    /**
     * @inheritdoc
     * @param Request $request
     */
    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        $this->getRouter()->setContext((new RequestContext())->fromRequest($request));

$request is of type object<Psr\Http\Message\ServerRequestInterface>, but the function expects a object<Symfony\Component\HttpFoundation\Request>.

        $return = $this->getRouter()->matchRequest($request);

$request is of type object<Psr\Http\Message\ServerRequestInterface>, but the function expects a object<Symfony\Component\HttpFoundation\Request>.

        if ($return['_route']) {
            $this->populateRequest($request, $return);

$request of type object<Psr\Http\Message\ServerRequestInterface> is not a sub-type of object<Nip\Request>. It seems like you assume a concrete implementation of the interface Psr\Http\Message\ServerRequestInterface to be always present.

        }

        return $handler->handle($request);
    }

    /**
     * @param Request $request
     * @param $params
     */
    protected function populateRequest($request, $params)

This method seems to be duplicated in your project.

    {
        foreach ($params as $param => $value) {
            switch ($param) {
                case 'module':
                    $request->setModuleName($value);
                    break;
                case 'controller':
                    $request->setControllerName($value);
                    break;
                case 'action':
                    $request->setActionName($value);
                    break;
                default:
                    $request->attributes->set($param, $value);
                    break;
            }
        }
    }

    /**
     * @return Router
     */
    public function getRouter(): Router
    {
        return $this->router;
    }
}