RouterTrait::newRouter() - Code Metrics - Inspection of "Merge branch '0.9' into develop" - bytic/router - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 1d7e99...ecdc34 )

by Gabriel

created 2019-11-05 19:49 UTC

RouterTrait::newRouter() A

↳ Parent: RouterTrait

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
nc	2
nop	0
dl	0
loc	10
ccs	6
cts	6
cp	1
crap	2
rs	9.9332
c	0
b	0
f	0

<?php

namespace Nip\Router\ServiceProvider\Traits;

use Nip\Request;
use Nip\Router\RequestContext;
use Nip\Router\Router;
use Symfony\Component\Routing\RouterInterface;

/**
 * Trait RouterTrait
 * @package Nip\Router\ServiceProvider\Traits
 */
trait RouterTrait
{
    public function registerRouter()
    {
        $this->getContainer()->share('router', function () {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            return $this->newRouter();
        });

        $this->getContainer()->add(RouterInterface::class, Router::class);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $this->getContainer()->share(Router::class, function () {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            return $this->getContainer()->get('router');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        });
    }

    /**
     * @return Router
     */
    public function newRouter()
    {
        /** @var Router $router */
        $router = $this->getContainer()->get(RouterInterface::class);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $request = Request::instance();
        if ($request instanceof Request) {
            $router->setContext((new RequestContext())->fromRequest($request));
        }
        return $router;
    }
}


1		<?php
2
3		namespace Nip\Router\ServiceProvider\Traits;
4
5		use Nip\Request;
6		use Nip\Router\RequestContext;
7		use Nip\Router\Router;
8		use Symfony\Component\Routing\RouterInterface;
9
10		/**
11		* Trait RouterTrait
12		* @package Nip\Router\ServiceProvider\Traits
13		*/
14		trait RouterTrait
15		{
16	2	public function registerRouter()
17		{
18		$this->getContainer()->share('router', function () {
		0 ignored issues – show Bug introduced 2019-03-27 07:21 UTC by Report Bug Copy Issue Report It seems like `getContainer()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
19	2	return $this->newRouter();
20	2	});
21
22	2	$this->getContainer()->add(RouterInterface::class, Router::class);
		0 ignored issues – show Bug introduced 2019-11-05 19:54 UTC by Report Bug Copy Issue Report It seems like `getContainer()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
23
24		$this->getContainer()->share(Router::class, function () {
		0 ignored issues – show Bug introduced 2019-11-05 19:54 UTC by Report Bug Copy Issue Report It seems like `getContainer()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
25		return $this->getContainer()->get('router');
		0 ignored issues – show Bug introduced 2019-11-05 19:54 UTC by Report Bug Copy Issue Report It seems like `getContainer()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
26	2	});
27	2	}
28
29		/**
30		* @return Router
31		*/
32	2	public function newRouter()
33		{
34		/** @var Router $router */
35	2	$router = $this->getContainer()->get(RouterInterface::class);
		0 ignored issues – show Bug introduced 2019-11-05 19:54 UTC by Report Bug Copy Issue Report It seems like `getContainer()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
36	2	$request = Request::instance();
37	2	if ($request instanceof Request) {
38	2	$router->setContext((new RequestContext())->fromRequest($request));
39		}
40	2	return $router;
41		}
42		}
43

bytic / router

Push — master ( 1d7e99...ecdc34 )

RouterTrait::newRouter() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like