LoaderTrait::createLoader() - Code Metrics - Inspection of "update routing to allow cache" - bytic/router - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 0c8b57...df0330 )

by Gabriel

created 2020-05-15 10:33 UTC

LoaderTrait::createLoader() A

↳ Parent: LoaderTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	18
rs	9.6666
c	0
b	0
f	0

<?php

namespace Nip\Router\ServiceProvider\Traits;

use Symfony\Component\Config\FileLocator;
use Symfony\Component\Routing\Loader\DirectoryLoader;
use Symfony\Component\Routing\Loader\PhpFileLoader;

/**
 * Trait LoaderTrait
 * @package Nip\Router\ServiceProvider\Traits
 */
trait LoaderTrait
{

    public function registerLoader()
    {
        $this->getContainer()->share('routing.loader', function () {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            return $this->createLoader();
        });
    }

    /**
     * @return \Symfony\Component\Config\Loader\DelegatingLoader
     */
    protected function createLoader()
    {
        $app = $this->getContainer()->get('app');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $locator = new FileLocator([
            $app->basePath() . DIRECTORY_SEPARATOR . 'routes',
            $app->path(),
            $app->basePath(),
        ]);

        $resolver = new \Symfony\Component\Config\Loader\LoaderResolver();
        $resolver->addLoader(new PhpFileLoader($locator));
        $resolver->addLoader(new DirectoryLoader($locator));

        $loader = new \Nip\Router\Loader\DelegatingLoader($resolver);

        return $loader;
    }
}


1			<?php
2
3			namespace Nip\Router\ServiceProvider\Traits;
4
5			use Symfony\Component\Config\FileLocator;
6			use Symfony\Component\Routing\Loader\DirectoryLoader;
7			use Symfony\Component\Routing\Loader\PhpFileLoader;
8
9			/**
10			* Trait LoaderTrait
11			* @package Nip\Router\ServiceProvider\Traits
12			*/
13			trait LoaderTrait
14			{
15
16			public function registerLoader()
17			{
18			$this->getContainer()->share('routing.loader', function () {
			0 ignored issues – show Bug introduced 2020-05-15 10:41 UTC by Report Bug Copy Issue Report It seems like `getContainer()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
19			return $this->createLoader();
20			});
21			}
22
23			/**
24			* @return \Symfony\Component\Config\Loader\DelegatingLoader
25			*/
26			protected function createLoader()
27			{
28			$app = $this->getContainer()->get('app');
			0 ignored issues – show Bug introduced 2020-05-15 10:41 UTC by Report Bug Copy Issue Report It seems like `getContainer()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
29
30			$locator = new FileLocator([
31			$app->basePath() . DIRECTORY_SEPARATOR . 'routes',
32			$app->path(),
33			$app->basePath(),
34			]);
35
36			$resolver = new \Symfony\Component\Config\Loader\LoaderResolver();
37			$resolver->addLoader(new PhpFileLoader($locator));
38			$resolver->addLoader(new DirectoryLoader($locator));
39
40			$loader = new \Nip\Router\Loader\DelegatingLoader($resolver);
41
42			return $loader;
43			}
44			}
45

bytic / router

Push — master ( 0c8b57...df0330 )

LoaderTrait::createLoader() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like