Nip\Router\Tests\Router\Traits\HasGeneratorTraitTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	57
Duplicated Lines	80.7 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	testGetGenerator()	0	5	1
A	testAssemble()	23	23	1
A	testGenerate()	23	23	1

<?php

namespace Nip\Router\Tests\Router\Traits;

use Nip\Router\Generator\UrlGenerator;
use Nip\Router\Route\Route;
use Nip\Router\RouteFactory;
use Nip\Router\Router;
use Nip\Router\Tests\AbstractTest;
use Nip\Router\Tests\Fixtures\Application\Library\Router\Route\StandardRoute;

/**
 * Class HasGeneratorTraitTest
 * @package Nip\Router\Tests\Router\Traits
 */
class HasGeneratorTraitTest extends AbstractTest
{

    public function testGetGenerator()
    {
        $router = new Router();
        self::assertInstanceOf(UrlGenerator::class, $router->getGenerator());
    }

    public function testAssemble()

This method seems to be duplicated in your project.

    {
        $router = new Router();
        $collection = $router->getRoutes();

        RouteFactory::generateLiteralRoute($collection, "admin.index", Route::class, "/admin", "/index");

It seems like $collection defined by $router->getRoutes() on line 28 can also be of type array<integer,object<Nip\Router\Route\Route>>; however, Nip\Router\RouteFactory::generateLiteralRoute() does only seem to accept object<Nip\Router\RouteCollection>, maybe add an additional type check?

        RouteFactory::generateStandardRoute($collection, "api.index", StandardRoute::class, "/api");

It seems like $collection defined by $router->getRoutes() on line 28 can also be of type array<integer,object<Nip\Router\Route\Route>>; however, Nip\Router\RouteFactory::generateStandardRoute() does only seem to accept object<Nip\Router\RouteCollection>, maybe add an additional type check?

        self::assertSame(
            '/admin/index?controller=posts',
            $router->assemble('admin.index', ['controller' => 'posts'])
        );

        self::assertSame(
            '/api/posts',
            $router->assemble('api.index', ['controller' => 'posts'])
        );

        self::assertSame(
            '/api/posts/create?test=true',
            $router->assemble('api.index', ['controller' => 'posts', 'action' => 'create', 'test' => 'true'])
        );
    }

    public function testGenerate()

This method seems to be duplicated in your project.

    {
        $router = new Router();
        $collection = $router->getRoutes();

        RouteFactory::generateLiteralRoute($collection, "admin.index", Route::class, "/admin", "/index");

It seems like $collection defined by $router->getRoutes() on line 52 can also be of type array<integer,object<Nip\Router\Route\Route>>; however, Nip\Router\RouteFactory::generateLiteralRoute() does only seem to accept object<Nip\Router\RouteCollection>, maybe add an additional type check?

        RouteFactory::generateStandardRoute($collection, "api.index", StandardRoute::class, "/api");

It seems like $collection defined by $router->getRoutes() on line 52 can also be of type array<integer,object<Nip\Router\Route\Route>>; however, Nip\Router\RouteFactory::generateStandardRoute() does only seem to accept object<Nip\Router\RouteCollection>, maybe add an additional type check?

        self::assertSame(
            '/admin/index?controller=posts',
            $router->generate('admin.index', ['controller' => 'posts'])
        );

        self::assertSame(
            '/api/posts',
            $router->generate('api.index', ['controller' => 'posts'])
        );

        self::assertSame(
            '/api/posts/create?param=test',
            $router->generate('api.index', ['controller' => 'posts','action' => 'create', 'param' => 'test'])
        );
    }
}