View GitHub Repository router

Schedule Inspection
Subscribe
Test Setup Failed
Push — master ( fc6567...89d4a6 )
by Gabriel
07:58
created

HasMatcherTrait::route()   A

↳ Parent: HasMatcherTrait

Complexity

Conditions 4
Paths 6

Size

Total Lines 23

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 14
CRAP Score 4

Importance

Changes 0
Metric Value
cc 4
nc 6
nop 1
dl 0
loc 23
ccs 14
cts 14
cp 1
crap 4
rs 9.552
c 0
b 0
f 0
1 
<?php
2 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    3
                

                                    
                                                    
                
                
                
namespace Nip\Router\Router\Traits;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                
use Nip\Request;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    6
                

                                    
                                                    
                
                
                
use Nip\Router\Route\Route;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    7
                

                                    
                                                    
                
                
                
use Psr\Http\Message\ServerRequestInterface;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                
/**

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                
 * Trait HasMatcherTrait

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
 * @package Nip\Router\Router\Traits

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                
 */

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                
trait HasMatcherTrait

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                
{

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
    /**

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                
     * @param Request|ServerRequestInterface $request

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    17
                

                                    
                                                    
                
                
                
     * @return array

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    18
                

                                    
                                                    
                
                
                
     */

            


            
                                                        
            
                                    
            
            

                
                    19
                

                                    
                             3                         
                
                
                
    public function route($request)

            


            
                                                        
            
                                    
            
            

                
                    20
                

                                    
                                                    
                
                
                
    {

            


            
                                                        
            
                                    
            
            

                
                    21
                

                                    
                             3                         
                
                
                
        $current = false;

            


            
                                                        
            
                                    
            
            

                
                    22
                

                                    
                             3                         
                
                
                
        $uri = $request->path();

            


            
                                                        
            
                                    
            
            

                
                    23
                

                                    
                             3                         
                
                
                
        $routes = $this->getRoutes();

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
It seems like getRoutes() must be provided by classes using this trait. How about adding it as abstract method to this trait?
                                                                                                

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
This check looks for methods that are used by a trait but not required by it.


To illustrate, let’s look at the following code example


trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}





The trait Idable provides a method equalsId that in turn relies on the
method getId(). If this method does not exist on a class mixing in this
trait, the method will fail.


Adding the getId() as an abstract method to the trait will make sure it
is available.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    24
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    25
                

                                    
                             3                         
                
                
                
        foreach ($routes as $name => $route) {

            


            
                                                        
            
                                    
            
            

                
                    26
                

                                    
                             2                         
                
                
                
            $route->setRequest($request);

            


            
                                                        
            
                                    
            
            

                
                    27
                

                                    
                             2                         
                
                
                
            if ($route->match($uri)) {

            


            
                                                        
            
                                    
            
            

                
                    28
                

                                    
                             2                         
                
                
                
                $current = $route;

            


            
                                                        
            
                                    
            
            

                
                    29
                

                                    
                             2                         
                
                
                
                break;

            


            
                                                        
            
                                    
            
            

                
                    30
                

                                    
                                                    
                
                
                
            }

            


            
                                                        
            
                                    
            
            

                
                    31
                

                                    
                                                    
                
                
                
        }

            


            
                                                        
            
                                    
            
            

                
                    32
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    33
                

                                    
                             3                         
                
                
                
        if ($current instanceof Route) {

            


            
                                                        
            
                                    
            
            

                
                    34
                

                                    
                             2                         
                
                
                
            $this->setCurrent($current);

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
It seems like setCurrent() must be provided by classes using this trait. How about adding it as abstract method to this trait?
                                                                                                

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
This check looks for methods that are used by a trait but not required by it.


To illustrate, let’s look at the following code example


trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}





The trait Idable provides a method equalsId that in turn relies on the
method getId(). If this method does not exist on a class mixing in this
trait, the method will fail.


Adding the getId() as an abstract method to the trait will make sure it
is available.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    35
                

                                    
                             2                         
                
                
                
            $current->populateRequest();

            


            
                                                        
            
                                    
            
            

                
                    36
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    37
                

                                    
                             2                         
                
                
                
            return $current->getParams() + $current->getMatches();

            


            
                                                        
            
                                    
            
            

                
                    38
                

                                    
                                                    
                
                
                
        } else {

            


            
                                                        
            
                                    
            
            

                
                    39
                

                                    
                             2                         
                
                
                
            return [];

            


            
                                                        
            
                                    
            
            

                
                    40
                

                                    
                                                    
                
                
                
        }

            


            
                                                        
            
                                    
            
            

                
                    41
                

                                    
                                                    
                
                
                
    }

            


            
                                                        
            
                                    
            
            

                
                    42
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    43
                

                                    
                                                    
                
                
                
}