Nip\Router\Router\Traits\HasGeneratorTrait

Complexity

Total Complexity

10

Size/Duplication

Total Lines	63
Duplicated Lines	38.1 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

34.62%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	assemble()	12	12	2
A	assembleFull()	12	12	2
A	getDefaultRoute()	0	18	6

<?php

namespace Nip\Router\Router\Traits;

use Nip\Router\Router;

/**
 * Trait HasGeneratorTrait
 * @package Nip\Router\Router\Traits
 */
trait HasGeneratorTrait
{

    /**
     * @param $name
     * @param boolean $params
     * @return string|null
     */
    public function assemble($name, $params = [])

This method seems to be duplicated in your project.

    {
        $route = $this->getDefaultRoute($name, $params);

It seems like $params defined by parameter $params on line 19 can also be of type boolean; however, Nip\Router\Router\Traits\HasGeneratorTrait::getDefaultRoute() does only seem to accept array, maybe add an additional type check?

        if ($route) {
            $route->setRequest($this->getRequest());

It seems like getRequest() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return $route->assemble($params);
        }

        trigger_error("Route \"$name\" not connected", E_USER_ERROR);
        return null;
    }

    /**
     * @param $name
     * @param boolean $params
     * @return string
     */
    public function assembleFull($name, $params = [])

This method seems to be duplicated in your project.

    {
        $route = $this->getDefaultRoute($name, $params);

It seems like $params defined by parameter $params on line 37 can also be of type boolean; however, Nip\Router\Router\Traits\HasGeneratorTrait::getDefaultRoute() does only seem to accept array, maybe add an additional type check?

        if ($route) {
            $route->setRequest($this->getRequest());

It seems like getRequest() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return $route->assembleFull($params);
        }

        trigger_error("Route \"$name\" not connected", E_USER_ERROR);

        return null;
    }

    /**
     * @param $name
     * @param array $params
     * @return null|Route\Route
     */
    public function getDefaultRoute($name, &$params = [])
    {
        $route = $this->getRoute($name);

It seems like getRoute() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if (!$route) {
            $parts = explode(".", $name);
            $count = count($parts);
            if ($count <= 3) {
                if (in_array(reset($parts), app('mvc.modules')->getNames())) {
                    $module = array_shift($parts);
                    $params['controller'] = isset($parts[0]) ? $parts[0] : null;
                    $params['action'] = isset($parts[1]) ? $parts[1] : null;
                    $route = $this->getRoute($module . '.default');

It seems like getRoute() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                }
            }
        }

        return $route;
    }
}