MatchingBench

Complexity

Total Complexity

6

Size/Duplication

Total Lines	52
Duplicated Lines	38.46 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	benchStaticRoutesNip()	0	5	1
A	benchDynamicRoutesNip()	0	5	1
A	benchStaticRoutesSymfony()	0	5	1
A	benchDynamicRoutesSymfony()	0	5	1
A	init()	20	20	2

<?php

use Nip\Request;
use Nip\Router\Route\Route;
use Nip\Router\RouteFactory;
use Nip\Router\Router;
use Nip\Router\Tests\Fixtures\Application\Library\Router\Route\StandardRoute;

/**
 * Class MatchingBench
 * @Iterations(5)
 * @Revs(100)
 * @BeforeMethods({"init"})
 */
class MatchingBench

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @var Router
     */
    protected $router;

    public function benchStaticRoutesNip()
    {
        $request = Request::create('/index999');
        $this->router->route($request);
    }

    public function benchDynamicRoutesNip()
    {
        $request = Request::create('/999/posts/create');
        $this->router->route($request);
    }

    public function benchStaticRoutesSymfony()
    {
        $request = Request::create('/index999');
        $this->router->matchRequest($request);
    }

    public function benchDynamicRoutesSymfony()
    {
        $request = Request::create('/999/posts/create');
        $this->router->matchRequest($request);
    }

    public function init()

This method seems to be duplicated in your project.

    {
        $this->router = new Router();
        $collection = $this->router->getRoutes();

        for ($i = 0; $i < 1000; ++$i) {
            RouteFactory::generateLiteralRoute(
                $collection,

It seems like $collection defined by $this->router->getRoutes() on line 49 can also be of type array<integer,object<Nip\Router\Route\Route>>; however, Nip\Router\RouteFactory::generateLiteralRoute() does only seem to accept object<Nip\Router\RouteCollection>, maybe add an additional type check?

                "index." . $i,
                Route::class,
                "",
                "/index" . $i);

            RouteFactory::generateStandardRoute(
                $collection,

It seems like $collection defined by $this->router->getRoutes() on line 49 can also be of type array<integer,object<Nip\Router\Route\Route>>; however, Nip\Router\RouteFactory::generateStandardRoute() does only seem to accept object<Nip\Router\RouteCollection>, maybe add an additional type check?

                "index.standard" . $i,
                StandardRoute::class,
                "/".$i);
        }
    }
}