Nip\Router\Tests\Router\Traits\HasMatcherTraitTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	56
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	testNotFound()	8	8	1
A	testRouteLiteral()	20	20	1
A	testRouteDynamic()	22	22	1

<?php

namespace Nip\Router\Tests\Router\Traits;

use Nip\Request;
use Nip\Router\Route\Route;
use Nip\Router\RouteFactory;
use Nip\Router\Router;
use Nip\Router\Tests\AbstractTest;
use Nip\Router\Tests\Fixtures\Application\Library\Router\Route\StandardRoute;
use Symfony\Component\Routing\Exception\ResourceNotFoundException;

/**
 * Class HasMatcherTraitTest
 * @package Nip\Router\Tests\Router\Traits
 */
class HasMatcherTraitTest extends AbstractTest

This class seems to be duplicated in your project.

{

    public function testNotFound()
    {
        $router = new Router();
        self::expectException(ResourceNotFoundException::class);

        $request = Request::create('/404');
        $router->matchRequest($request);
    }

    public function testRouteLiteral()
    {
        $router = new Router();
        $collection = $router->getRoutes();

        RouteFactory::generateLiteralRoute($collection, "admin.index", Route::class, "/admin", "/index");

It seems like $collection defined by $router->getRoutes() on line 32 can also be of type array<integer,object<Nip\Router\Route\Route>>; however, Nip\Router\RouteFactory::generateLiteralRoute() does only seem to accept object<Nip\Router\RouteCollection>, maybe add an additional type check?

        RouteFactory::generateLiteralRoute($collection, "api.index", Route::class, "/api", "/index");

It seems like $collection defined by $router->getRoutes() on line 32 can also be of type array<integer,object<Nip\Router\Route\Route>>; however, Nip\Router\RouteFactory::generateLiteralRoute() does only seem to accept object<Nip\Router\RouteCollection>, maybe add an additional type check?

        $request = Request::create('/api/index');
        $params = $router->matchRequest($request);
        self::assertEquals(['_route' => 'api.index'], $params);

        $currentRoute = $router->getCurrent();
        self::assertInstanceOf(Route::class, $currentRoute);
        self::assertEquals('api.index', $currentRoute->getName());

        $request = Request::create('/admin/index');
        $router->matchRequest($request);
        self::assertEquals('admin.index', $router->getCurrent()->getName());
    }

    public function testRouteDynamic()
    {
        $router = new Router();
        $collection = $router->getRoutes();

        RouteFactory::generateStandardRoute($collection, "admin.standard", StandardRoute::class, "/admin",

It seems like $collection defined by $router->getRoutes() on line 53 can also be of type array<integer,object<Nip\Router\Route\Route>>; however, Nip\Router\RouteFactory::generateStandardRoute() does only seem to accept object<Nip\Router\RouteCollection>, maybe add an additional type check?

            '/:controller/:action', ['module' => 'admin']);
        RouteFactory::generateStandardRoute($collection, "api.standard", StandardRoute::class, "/api",

It seems like $collection defined by $router->getRoutes() on line 53 can also be of type array<integer,object<Nip\Router\Route\Route>>; however, Nip\Router\RouteFactory::generateStandardRoute() does only seem to accept object<Nip\Router\RouteCollection>, maybe add an additional type check?

            '/:controller/:action', ['module' => 'api']);

        $request = Request::create('/api/pages/delete');
        self::assertEquals(
            ['module' => 'api', 'controller' => 'pages', 'action' => 'delete', '_route' => 'api.standard'],
            $router->matchRequest($request)
        );

        $request = Request::create('/admin/pages/delete');
        self::assertEquals(
            ['module' => 'admin', 'controller' => 'pages', 'action' => 'delete', '_route' => 'admin.standard'],
            $router->matchRequest($request)
        );
    }
}