RouteResolverMiddlewareTest::testProcess() - Code Metrics - Inspection of "add container to repo" - bytic/router - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b9a9e3...539ccc )

by Gabriel

created 2018-02-19 14:35 UTC

RouteResolverMiddlewareTest::testProcess() A

↳ Parent: RouteResolverMiddlewareTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	19
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	9
nc	1
nop	0

<?php

namespace Nip\Router\Tests\Middleware;

use Nip\Router\Middleware\RouteResolverMiddleware;
use Nip\Router\Router;
use Nip\Router\Tests\AbstractTest;
use Nip\Http\Response\Response;
use Nip\Http\ServerMiddleware\Dispatcher;
use Nip\Request;

/**
 * Class DebugbarMiddlewareTest
 * @package Nip\Router\Tests\Middleware
 */
class RouteResolverMiddlewareTest extends AbstractTest
{

    public function testProcess()
    {
        $router = new Router();

        $dispatcher = new Dispatcher(
            [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                new RouteResolverMiddleware($router),
                function () {
                    return (new Response())->setContent('test');
                },
            ]
        );

        /** @var Response $response */
        $response = $dispatcher->dispatch(new Request());

        self::assertInstanceOf(Response::class, $response);
        self::assertSame('test', $response->getContent());
    }
}


1			<?php
2
3			namespace Nip\Router\Tests\Middleware;
4
5			use Nip\Router\Middleware\RouteResolverMiddleware;
6			use Nip\Router\Router;
7			use Nip\Router\Tests\AbstractTest;
8			use Nip\Http\Response\Response;
9			use Nip\Http\ServerMiddleware\Dispatcher;
10			use Nip\Request;
11
12			/**
13			* Class DebugbarMiddlewareTest
14			* @package Nip\Router\Tests\Middleware
15			*/
16			class RouteResolverMiddlewareTest extends AbstractTest
17			{
18
19			public function testProcess()
20			{
21			$router = new Router();
22
23			$dispatcher = new Dispatcher(
24			[
			0 ignored issues – show Documentation introduced 2018-02-19 14:38 UTC by Report Bug Copy Issue Report `array(new \Nip\Router\Mi...>setContent('test'); })` is of type `array<integer,object<Nip..."1":"object<Closure>"}>`, but the function expects a `array<integer,object<Psr...r\MiddlewareInterface>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
25			new RouteResolverMiddleware($router),
26			function () {
27			return (new Response())->setContent('test');
28			},
29			]
30			);
31
32			/** @var Response $response */
33			$response = $dispatcher->dispatch(new Request());
34
35			self::assertInstanceOf(Response::class, $response);
36			self::assertSame('test', $response->getContent());
37			}
38			}
39

bytic / router

Push — master ( b9a9e3...539ccc )

RouteResolverMiddlewareTest::testProcess() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like