Nip\Router\Route\Traits\HasMatchTrait

Complexity

Total Complexity

5

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	domainCheck()	0	3	1
A	postMatch()	0	2	1
A	match()	0	13	3

<?php

namespace Nip\Router\Route\Traits;

/**
 * Trait HasMatchTrait
 * @package Nip\Router\Route\Traits
 */
trait HasMatchTrait
{

    /**
     * @param $uri
     * @return bool
     */
    public function match($uri)
    {
        $this->uri = $uri;

The property uri does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        if ($this->domainCheck()) {
            $return = $this->getParser()->match($uri);

It seems like getParser() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            if ($return === true) {
                $this->postMatch();
            }

            return $return;
        }

        return false;
    }

    /**
     * @return bool
     */
    public function domainCheck()
    {
        return true;
    }

    public function postMatch()
    {
    }
}