Nip\Router\Generator\Traits\HasPreviousUrlTrait

Complexity

Total Complexity

5

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getPreviousUrlFromSession()	0	3	1
A	previous()	0	10	4

<?php

namespace Nip\Router\Generator\Traits;

use Nip\Router\RequestContext;

/**
 * Trait HasPreviousUrlTrait
 * @package Nip\Router\Generator\Traits
 * @method RequestContext getContext()
 */
trait HasPreviousUrlTrait
{

    /**
     * Get the URL for the previous request.
     *
     * @param  mixed $fallback
     * @return string
     */
    public function previous($fallback = false)
    {
        $referrer = $this->getContext()->getHeaders()->get('referer');
        $url = $referrer ? $this->to($referrer) : $this->getPreviousUrlFromSession();

Are you sure the usage of $this->getPreviousUrlFromSession() targeting Nip\Router\Generator\Traits\HasPreviousUrlTrait::getPreviousUrlFromSession() seems to always return null.

It seems like to() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if ($url) {
            return $url;
        } elseif ($fallback) {
            return $this->to($fallback);
        } else {
            return $this->to('/');
        }
    }

    /**
     * Get the previous URL from the session if possible.
     *
     * @return string|null
     */
    protected function getPreviousUrlFromSession()
    {
        return null;
//        $session = $this->getSession();
//        return $session ? $session->previousUrl() : null;
    }
}