ByTIC\Payments\Mobilpay\Tests\FileLoader\HasFileLoaderTest::testSaveToModelOptions()

Complexity

Conditions	1
Paths	1

Size

Total Lines	38
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function testSaveToModelOptions()
    {
        /** @var PaymentMethod $paymentMethod */
        $paymentMethods = \Mockery::mock(PaymentMethods::class)->makePartial();
        $paymentMethods->shouldReceive('save');

        ModelLocator::set(PaymentMethods::class, $paymentMethods);

$paymentMethods of type Mockery\Mock is incompatible with the type Nip\Records\AbstractModels\RecordManager expected by parameter $entityManager of Nip\Records\Locator\ModelLocator::set().

        $paymentMethod = new PaymentMethod();

        $paymentMethod->type = 'credit-cards';

The property type does not exist on ByTIC\Payments\Mobilpay\Tests\Fixtures\Records\PaymentMethods\PaymentMethod. Since you implemented __set, consider adding a @property annotation.

        $options = unserialize(MobilpayData::getMethodOptions());
        $options['mobilpay']['file'] = 'public.cer';
        $options['mobilpay']['private-key'] = 'private.key';
        $paymentMethod->options = serialize($options);

        $type = new CreditCards();
        $type->setItem($paymentMethod);
        $paymentMethod->setType($type);

        $directoryPath = $paymentMethod->getFilesDirectory();
        MobilpayData::buildCertificates();
        self::assertDirectoryExists($directoryPath);

        /** @var Gateway $gateway */
        $gateway = $paymentMethod->getType()->getGateway();

The method getGateway() does not exist on ByTIC\Payments\Models\Methods\Types\AbstractType. It seems like you code against a sub-type of ByTIC\Payments\Models\Methods\Types\AbstractType such as ByTIC\Payments\Models\Methods\Types\CreditCards.

        self::assertGreaterThan(5, strlen($gateway->getCertificate()));

It seems like $gateway->getCertificate() can also be of type null; however, parameter $string of strlen() does only seem to accept string, maybe add an additional type check?

        self::assertGreaterThan(5, strlen($gateway->getPrivateKey()));

        $options = $paymentMethod->getPaymentGatewayOptions();

        self::assertArrayNotHasKey('file', $options);
        self::assertArrayNotHasKey('private-key', $options);

        self::assertGreaterThan(50, strlen($options['certificate']));
        self::assertGreaterThan(50, strlen($options['privateKey']));
        self::assertDirectoryNotExists($directoryPath);
    }