Nip\Records\Relations\HasOneOrMany

Complexity

Total Complexity

18

Size/Duplication

Total Lines	130
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	8

Test Coverage

Coverage

30%

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	save()	0	10	3
A	hasResults()	0	4	2
A	initResults()	0	8	1
A	populateCollection()	0	6	2
A	getResultsFromCollectionDictionary()	0	13	3
A	buildDictionary()	0	9	2
A	getDictionaryKey()	0	4	1
A	saveResult()	0	7	1
A	populateEagerQueryFromFkList()	0	5	1
A	getEagerFkList()	0	10	2

<?php

namespace Nip\Records\Relations;

use Nip\Database\Query\Select as Query;
use Nip\HelperBroker;
use Nip\Records\AbstractModels\Record as Record;
use Nip\Records\Collections\Associated as AssociatedCollection;
use Nip\Records\Collections\Collection;
use Nip\Records\Collections\Collection as RecordCollection;
use Nip\Records\Relations\Traits\HasCollectionResults;

/**
 * Class HasOneOrMany
 * @package Nip\Records\Relations
 */
abstract class HasOneOrMany extends Relation
{
    use HasCollectionResults;

    /**
     * @var string
     */
    protected $type = 'hasMany';

    /**
     * @return bool
     */
    public function save()
    {
        if ($this->hasResults()) {
            $collection = $this->getResults();
            foreach ($collection as $item) {

The expression $collection of type object<Nip\Records\Collections\Collection>|object<Nip\Records\Record> is not guaranteed to be traversable. How about adding an additional type check?

                $this->saveResult($item);
            }
        }
        return true;
    }

    /**
     * @return bool
     */
    public function hasResults()
    {
        return $this->isPopulated() && count($this->getResults()) > 0;
    }

    /**
     * @param Record $item
     */
    public function saveResult(Record $item)
    {
        $pk = $this->getManager()->getPrimaryKey();
        $fk = $this->getFK();
        $item->{$fk} = $this->getItem()->{$pk};
        $item->saveRecord();
    }

    public function initResults()
    {
        $query = $this->getQuery();
        $items = $this->getWith()->findByQuery($query);
        $collection = $this->newCollection();
        $this->populateCollection($collection, $items);
        $this->setResults($collection);
    }

    /**
     * @param RecordCollection $collection
     * @param Collection $items
     */
    public function populateCollection(RecordCollection $collection, $items)
    {
        foreach ($items as $item) {
            $collection->add($item);
        }
    }

    /** @noinspection PhpMissingParentCallCommonInspection
     * @inheritdoc
     */
    public function populateEagerQueryFromFkList($query, $fkList)
    {
        $query->where($this->getFK() . ' IN ?', $fkList);
        return $query;
    }

    /** @noinspection PhpMissingParentCallCommonInspection
     * @param RecordCollection $collection
     * @return array
     */
    public function getEagerFkList(RecordCollection $collection)
    {
        if ($collection->isEmpty()) {
            return [];
        }
        $key = $collection->getManager()->getPrimaryKey();
        $return = HelperBroker::get('Arrays')->pluck($collection, $key);

It seems like you code against a specific sub-type and not the parent class Nip\Helpers\AbstractHelper as the method pluck() does only exist in the following sub-classes of Nip\Helpers\AbstractHelper: Nip_Helper_Arrays. Maybe you want to instanceof check for one of these explicitly?

        return array_unique($return);
    }

    /**
     * @param array $dictionary
     * @param Collection $collection
     * @param Record $record
     * @return AssociatedCollection
     */
    public function getResultsFromCollectionDictionary($dictionary, $collection, $record)
    {
        $fk = $record->getManager()->getPrimaryKey();
        $pk = $record->{$fk};
        $collection = $this->newCollection();

        if ($dictionary[$pk]) {
            foreach ($dictionary[$pk] as $record) {
                $collection->add($record);
            }
        }
        return $collection;
    }

    /**
     * Build model dictionary keyed by the relation's foreign key.
     *
     * @param RecordCollection $collection
     * @return array
     */
    protected function buildDictionary(RecordCollection $collection)
    {
        $dictionary = [];
        $pk = $this->getDictionaryKey();
        foreach ($collection as $record) {
            $dictionary[$record->{$pk}][] = $record;
        }
        return $dictionary;
    }

    /**
     * @return string
     */
    protected function getDictionaryKey()
    {
        return $this->getFK();
    }
}