Nip\Records\Collections\Associated

Complexity

Total Complexity

7

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

65%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	save()	0	4	1
A	getWithRelation()	0	4	1
A	getItem()	0	4	1
A	initFromRelation()	0	10	2
A	setWithRelation()	0	4	1
A	setItem()	0	4	1

<?php

namespace Nip\Records\Collections;

use Nip\Records\Collections\Collection as RecordCollection;
use Nip\Records\Record as Record;
use Nip\Records\Relations\HasOneOrMany as Relation;
use Nip\Records\Relations\Traits\HasCollectionResults;

class Associated extends RecordCollection
{

    /**
     * @var Relation
     */
    protected $_withRelation;

    /**
     * @var Record
     */
    protected $_item;

    /**
     * @param HasCollectionResults $relation

The type HasCollectionResults for parameter $relation is a trait, and thus cannot be used for type-hinting in PHP. Maybe consider adding an interface and use that for type-hinting?

     */
    public function initFromRelation($relation)
    {
        $this->setWithRelation($relation);
        $this->setManager($relation->getWith());

It seems like getWith() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->setItem($relation->getItem());

It seems like getItem() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $indexKey = $relation->getParam('indexKey');
        if ($indexKey) {
            $this->setIndexKey($indexKey);
        }
    }

    public function save()
    {
        return $this->getWithRelation()->save();
    }

    /**
     * @return Relation
     */
    public function getWithRelation()
    {
        return $this->_withRelation;
    }

    /**
     * @param Relation $relation
     */
    public function setWithRelation($relation)
    {
        $this->_withRelation = $relation;
    }

    /**
     * @return Record
     */
    public function getItem()
    {
        return $this->_item;
    }

    /**
     * @param Record $item
     */
    public function setItem($item)
    {
        $this->_item = $item;
    }
}