RecordsTrait::initUniqueFields() - Code Metrics - Inspection of "add getFK new method in HABTM relation" - bytic/orm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4ac004...470d43 )

by Gabriel

created 2018-11-20 08:54 UTC

RecordsTrait::initUniqueFields() A

↳ Parent: RecordsTrait

Complexity

Conditions	4
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	7
cts	7
cp	1
rs	9.8666
c	0
b	0
f	0
cc	4
nc	3
nop	0
crap	4

<?php

namespace Nip\Records\Traits\Unique;

use Nip\Database\Query\Condition\Condition;
use Nip\Records\AbstractModels\Record;

/**
 * Class RecordsTrait
 * @package Nip\Records\Traits\Unique
 */
trait RecordsTrait
{
    protected $uniqueFields = null;

    /**
     * @param Record $item
     * @return bool|false|Record
     */
    public function exists(Record $item)
    {
        $params = $this->generateExistsParams($item);

        if (!$params) {
            return false;
        }
        return $this->findOneByParams($params);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param Record $item
     * @return array|bool
     */
    public function generateExistsParams(Record $item)
    {
        $params = [];
        $params['where'] = [];

        $uniqueFields = $this->getUniqueFields();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        if (!$uniqueFields) {
            return false;
        }

        foreach ($uniqueFields as $uniqueName => $fields) {
            $conditions = [];
            foreach ($fields as $field) {
                $conditions[] = "`$field` = '{$item->{$field}}'";
            }
            $params['where'][$uniqueName . '-UNQ'] = implode(' AND ', $conditions);
        }

        $pk = $this->getPrimaryKey();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        if ($item->getPrimaryKey()) {
            $params['where'][] = ["$pk != ?", $item->getPrimaryKey()];
        }
        return $params;
    }

    /**
     * @return null
     */
    public function getUniqueFields()
    {
        if ($this->uniqueFields === null) {
            $this->initUniqueFields();
        }

        return $this->uniqueFields;
    }

    /**
     * @return array|null
     */
    public function initUniqueFields()
    {
        $this->uniqueFields = [];
        $structure = $this->getTableStructure();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        foreach ($structure['indexes'] as $name => $index) {
            if ($index['unique'] && $name != 'PRIMARY') {
                $this->uniqueFields[$name] = $index['fields'];
            }
        }

        return $this->uniqueFields;
    }
}


1		<?php
2
3		namespace Nip\Records\Traits\Unique;
4
5		use Nip\Database\Query\Condition\Condition;
6		use Nip\Records\AbstractModels\Record;
7
8		/**
9		* Class RecordsTrait
10		* @package Nip\Records\Traits\Unique
11		*/
12		trait RecordsTrait
13		{
14		protected $uniqueFields = null;
15
16		/**
17		* @param Record $item
18		* @return bool\|false\|Record
19		*/
20		public function exists(Record $item)
21		{
22		$params = $this->generateExistsParams($item);
23
24		if (!$params) {
25		return false;
26		}
27		return $this->findOneByParams($params);
		0 ignored issues – show Bug introduced 2018-11-20 09:01 UTC by Report Bug Copy Issue Report It seems like `findOneByParams()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
28		}
29
30		/**
31		* @param Record $item
32		* @return array\|bool
33		*/
34	1	public function generateExistsParams(Record $item)
35		{
36	1	$params = [];
37	1	$params['where'] = [];
38
39	1	$uniqueFields = $this->getUniqueFields();
		0 ignored issues – show Bug introduced 2018-11-20 09:01 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$uniqueFields` is correct as `$this->getUniqueFields()` (which targets `Nip\Records\Traits\Uniqu...rait::getUniqueFields()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
40
41	1	if (!$uniqueFields) {
42		return false;
43		}
44
45	1	foreach ($uniqueFields as $uniqueName => $fields) {
46	1	$conditions = [];
47	1	foreach ($fields as $field) {
48	1	$conditions[] = "`$field` = '{$item->{$field}}'";
49		}
50	1	$params['where'][$uniqueName . '-UNQ'] = implode(' AND ', $conditions);
51		}
52
53	1	$pk = $this->getPrimaryKey();
		0 ignored issues – show Bug introduced 2018-11-20 09:01 UTC by Report Bug Copy Issue Report It seems like `getPrimaryKey()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
54	1	if ($item->getPrimaryKey()) {
55		$params['where'][] = ["$pk != ?", $item->getPrimaryKey()];
56		}
57	1	return $params;
58		}
59
60		/**
61		* @return null
62		*/
63	2	public function getUniqueFields()
64		{
65	2	if ($this->uniqueFields === null) {
66	2	$this->initUniqueFields();
67		}
68
69	2	return $this->uniqueFields;
70		}
71
72		/**
73		* @return array\|null
74		*/
75	2	public function initUniqueFields()
76		{
77	2	$this->uniqueFields = [];
78	2	$structure = $this->getTableStructure();
		0 ignored issues – show Bug introduced 2018-11-20 09:01 UTC by Report Bug Copy Issue Report It seems like `getTableStructure()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
79	2	foreach ($structure['indexes'] as $name => $index) {
80	2	if ($index['unique'] && $name != 'PRIMARY') {
81	2	$this->uniqueFields[$name] = $index['fields'];
82		}
83		}
84
85	2	return $this->uniqueFields;
86		}
87		}
88

bytic / orm

Push — master ( 4ac004...470d43 )

RecordsTrait::initUniqueFields() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like