HasPivotTable - Code Metrics - Inspection of "add getFK new method in HABTM relation" - bytic/orm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4ac004...470d43 )

by Gabriel

created 2018-11-20 08:54 UTC

HasPivotTable A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

77.78%

Importance

Changes

Metric	Value
wmc	6
lcom	0
cbo	3
dl	0
loc	55
ccs	14
cts	18
cp	0.7778
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	addPivotParams()	5	1
A	getDB()	4	2
A	generateTable()	4	1
A	generatePivotTable()	10	1
A	hydrateQueryWithPivotConstraints()	6	1

<?php

namespace Nip\Records\Relations\Traits;

use Nip\Database\Connections\Connection;
use Nip\Database\Query\Select as SelectQuery;

/**
 * Trait HasPivotTable
 * @package Nip\Records\Relations\Traits
 */
trait HasPivotTable
{
    use HasPivotForeignKey;
    use HasPivotPrimaryKey;

    /**
     * @param $params
     */
    public function addPivotParams($params)
    {
        $this->checkParamPivotFk($params);
        $this->checkParamPivotPrimaryKey($params);
    }

    /**
     * @return Connection
     */
    public function getDB()
    {
        return $this->getParam("link-db") == 'with' ? $this->getWith()->getDB() : parent::getDB();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /** @noinspection PhpMissingParentCallCommonInspection
     * @return string
     */
    public function generateTable()
    {
        return $this->generatePivotTable();
    }

    /**
     * Builds the name of a has-and-belongs-to-many association table
     * @return string
     */
    public function generatePivotTable()
    {
        $tables = [
            $this->getManager()->getTable(),
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->getWith()->getTable()
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        ];
        sort($tables);

        return implode("_", $tables);
    }

    /**
     * @param SelectQuery $query
     */
    protected function hydrateQueryWithPivotConstraints($query)
    {
        $pk = $this->getPivotPrimaryKey();
        $fk = $this->getPivotFK();
        $query->where("`{$this->getTable()}`.`$fk` = `{$this->getWith()->getTable()}`.`$pk`");
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1		<?php
2
3		namespace Nip\Records\Relations\Traits;
4
5		use Nip\Database\Connections\Connection;
6		use Nip\Database\Query\Select as SelectQuery;
7
8		/**
9		* Trait HasPivotTable
10		* @package Nip\Records\Relations\Traits
11		*/
12		trait HasPivotTable
13		{
14		use HasPivotForeignKey;
15		use HasPivotPrimaryKey;
16
17		/**
18		* @param $params
19		*/
20		public function addPivotParams($params)
21		{
22		$this->checkParamPivotFk($params);
23		$this->checkParamPivotPrimaryKey($params);
24		}
25
26		/**
27		* @return Connection
28		*/
29	1	public function getDB()
30		{
31	1	return $this->getParam("link-db") == 'with' ? $this->getWith()->getDB() : parent::getDB();
		0 ignored issues – show Bug introduced 2018-02-02 00:15 UTC by Report Bug Copy Issue Report It seems like `getParam()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2018-02-02 00:15 UTC by Report Bug Copy Issue Report It seems like `getWith()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
32		}
33
34		/** @noinspection PhpMissingParentCallCommonInspection
35		* @return string
36		*/
37	2	public function generateTable()
38		{
39	2	return $this->generatePivotTable();
40		}
41
42		/**
43		* Builds the name of a has-and-belongs-to-many association table
44		* @return string
45		*/
46	1	public function generatePivotTable()
47		{
48		$tables = [
49	1	$this->getManager()->getTable(),
		0 ignored issues – show Bug introduced 2018-02-02 00:15 UTC by Report Bug Copy Issue Report It seems like `getManager()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
50	1	$this->getWith()->getTable()
		0 ignored issues – show Bug introduced 2018-02-02 00:15 UTC by Report Bug Copy Issue Report It seems like `getWith()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
51		];
52	1	sort($tables);
53
54	1	return implode("_", $tables);
55		}
56
57		/**
58		* @param SelectQuery $query
59		*/
60	1	protected function hydrateQueryWithPivotConstraints($query)
61		{
62	1	$pk = $this->getPivotPrimaryKey();
63	1	$fk = $this->getPivotFK();
64	1	$query->where("`{$this->getTable()}`.`$fk` = `{$this->getWith()->getTable()}`.`$pk`");
		0 ignored issues – show Bug introduced 2018-02-02 00:15 UTC by Report Bug Copy Issue Report It seems like `getTable()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2018-02-02 00:15 UTC by Report Bug Copy Issue Report It seems like `getWith()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
65	1	}
66		}
67

bytic / orm

Push — master ( 4ac004...470d43 )

HasPivotTable A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

Duplication Side-by-Side

Filter issues like