HasPivotTable - Code Metrics - Inspection of "add new stage to Locator resolver" - bytic/orm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3a177f...0ba58c )

by Gabriel

created 2018-02-20 14:59 UTC

HasPivotTable A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	6
lcom	0
cbo	1
dl	0
loc	52
ccs	16
cts	16
cp	1
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	getDB()	4	2
A	generateTable()	4	1
A	hydrateQueryWithPivotConstraints()	6	1
A	getPivotFK()	4	1
A	generatePivotTable()	10	1

<?php

namespace Nip\Records\Relations\Traits;

use Nip\Database\Connections\Connection;
use Nip\Database\Query\Select as SelectQuery;

/**
 * Trait HasPivotTable
 * @package Nip\Records\Relations\Traits
 */
trait HasPivotTable
{

    /**
     * @return Connection
     */
    public function getDB()
    {
        return $this->getParam("link-db") == 'with' ? $this->getWith()->getDB() : parent::getDB();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /** @noinspection PhpMissingParentCallCommonInspection
     * @return string
     */
    public function generateTable()
    {
        return $this->generatePivotTable();
    }

    /**
     * Builds the name of a has-and-belongs-to-many association table
     * @return string
     */
    public function generatePivotTable()
    {
        $tables = [
            $this->getManager()->getTable(),
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->getWith()->getTable()
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        ];
        sort($tables);

        return implode("_", $tables);
    }

    /**
     * @param SelectQuery $query
     */
    protected function hydrateQueryWithPivotConstraints($query)
    {
        $pk = $this->getWith()->getPrimaryKey();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $fk = $this->getPivotFK();
        $query->where("`{$this->getTable()}`.`$fk` = `{$this->getWith()->getTable()}`.`$pk`");
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @return mixed
     */
    protected function getPivotFK()
    {
        return $this->getWith()->getPrimaryFK();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1		<?php
2
3		namespace Nip\Records\Relations\Traits;
4
5		use Nip\Database\Connections\Connection;
6		use Nip\Database\Query\Select as SelectQuery;
7
8		/**
9		* Trait HasPivotTable
10		* @package Nip\Records\Relations\Traits
11		*/
12		trait HasPivotTable
13		{
14
15		/**
16		* @return Connection
17		*/
18	1	public function getDB()
19		{
20	1	return $this->getParam("link-db") == 'with' ? $this->getWith()->getDB() : parent::getDB();
		0 ignored issues – show Bug introduced 2018-02-02 00:15 UTC by Report Bug Copy Issue Report It seems like `getParam()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2018-02-02 00:15 UTC by Report Bug Copy Issue Report It seems like `getWith()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
21		}
22
23		/** @noinspection PhpMissingParentCallCommonInspection
24		* @return string
25		*/
26	2	public function generateTable()
27		{
28	2	return $this->generatePivotTable();
29		}
30
31		/**
32		* Builds the name of a has-and-belongs-to-many association table
33		* @return string
34		*/
35	1	public function generatePivotTable()
36		{
37		$tables = [
38	1	$this->getManager()->getTable(),
		0 ignored issues – show Bug introduced 2018-02-02 00:15 UTC by Report Bug Copy Issue Report It seems like `getManager()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
39	1	$this->getWith()->getTable()
		0 ignored issues – show Bug introduced 2018-02-02 00:15 UTC by Report Bug Copy Issue Report It seems like `getWith()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
40		];
41	1	sort($tables);
42
43	1	return implode("_", $tables);
44		}
45
46		/**
47		* @param SelectQuery $query
48		*/
49	1	protected function hydrateQueryWithPivotConstraints($query)
50		{
51	1	$pk = $this->getWith()->getPrimaryKey();
		0 ignored issues – show Bug introduced 2018-02-02 00:15 UTC by Report Bug Copy Issue Report It seems like `getWith()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
52	1	$fk = $this->getPivotFK();
53	1	$query->where("`{$this->getTable()}`.`$fk` = `{$this->getWith()->getTable()}`.`$pk`");
		0 ignored issues – show Bug introduced 2018-02-02 00:15 UTC by Report Bug Copy Issue Report It seems like `getTable()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2018-02-02 00:15 UTC by Report Bug Copy Issue Report It seems like `getWith()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
54	1	}
55
56		/**
57		* @return mixed
58		*/
59	1	protected function getPivotFK()
60		{
61	1	return $this->getWith()->getPrimaryFK();
		0 ignored issues – show Bug introduced 2018-02-02 00:15 UTC by Report Bug Copy Issue Report It seems like `getWith()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
62		}
63		}
64

bytic / orm

Push — master ( 3a177f...0ba58c )

HasPivotTable A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

Duplication Side-by-Side

Filter issues like