Nip\Records\Traits\HasPrimaryKey\RecordTrait

Complexity

Total Complexity

7

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	generateCompositePrimaryKey()	0	8	3
A	hasPrimaryKey()	0	7	2
A	getPrimaryKey()	0	9	2

<?php

namespace Nip\Records\Traits\HasPrimaryKey;

/**
 * Trait RecordTrait
 * @package Nip\Records\Traits\HasPrimaryKey
 */
trait RecordTrait
{
    /**
     * @return mixed
     */
    public function getPrimaryKey()
    {
        $primaryKey = $this->getManager()->getPrimaryKey();

It seems like getManager() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if (is_array($primaryKey)) {
            return $this->generateCompositePrimaryKey($primaryKey);
        }

        return $this->{$primaryKey};
    }

    /**
     * @param null $primaryKey

Are you sure the doc-type for parameter $primaryKey is correct as it would always require null to be passed?

     * @return array
     */
    protected function generateCompositePrimaryKey($primaryKey = null)
    {
        $primaryKey = $primaryKey ? $primaryKey : $this->getManager()->getPrimaryKey();

$primaryKey is of type null, thus it always evaluated to false.

        $return = [];
        foreach ($primaryKey as $key) {
            $return[$key] = $this->{$key};
        }
        return $return;
    }

    /**
     * @return bool
     */
    public function hasPrimaryKey()
    {
        $key = $this->getPrimaryKey();
        if (is_array($key)) {
            $key = array_filter($key);
        }
        return !empty($key);
    }
}