Nip\Records\Traits\HasUrl\HasUrlRecordManagerTrait

Complexity

Total Complexity

13

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	compileURL()	0	31	8
A	isCallUrl()	0	11	5

<?php

namespace Nip\Records\Traits\HasUrl;

/**
 * Trait HasUrlRecordManagerTrait
 * @package Nip\Records\Traits\HasUrl
 */
trait HasUrlRecordManagerTrait
{

    /**
     * @param string $name
     * @param $arguments
     * @return bool
     */
    protected function isCallUrl($name, $arguments)
    {
        if (substr($name, 0, 3) == "get" && substr($name, -3) == "URL") {
            $action = substr($name, 3, -3);
            $params = isset($arguments[0]) ? $arguments[0] : [];
            $module = isset($arguments[1]) ? $arguments[1] : null;

            return $this->compileURL($action, $params, $module);

The expression return $this->compileURL($action, $params, $module) also could return the type string which is incompatible with the documented return type boolean.

        }

        return false;
    }

    /**
     * @param string $action
     * @param array $params
     * @param null $module

Are you sure the doc-type for parameter $module is correct as it would always require null to be passed?

     * @return string|null
     */
    public function compileURL($action, $params = [], $module = null)
    {
        $controller = $this->getController();

It seems like getController() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if (substr($action, 0, 5) == 'Async') {
            $controller = 'async-' . $controller;
            $action = substr($action, 5);
        }

        if (substr($action, 0, 5) == 'Modal') {
            $controller = 'modal-' . $controller;
            $action = substr($action, 5);
        }

        $params['action'] = (!empty($action)) ? $action : 'index';
        $params['controller'] = $controller;

        $params['action'] = inflector()->unclassify($params['action']);
        $params['action'] = ($params['action'] == 'index') ? null : $params['action'];

        $params['controller'] = $controller ? $controller : $this->getController();
        $params['module'] = $module ? $module : request()->getModuleName();

The function request was not found. Maybe you did not declare it correctly or list all dependencies?

$module is of type null, thus it always evaluated to false.

        $routeName = $params['module'] . '.' . $params['controller'] . '.' . $params['action'];
        if (app()->get('router')->hasRoute($routeName)) {

The function app was not found. Maybe you did not declare it correctly or list all dependencies?

            unset($params['module'], $params['controller'], $params['action']);
        } else {
            $routeName = $params['module'] . '.default';
        }

        return app()->get('router')->assembleFull($routeName, $params);
    }
}