MorphOneOrMany - Code Metrics - Inspection of "fix MorphMany relations populateQuery" - bytic/orm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c5047e...3a177f )

by Gabriel

created 2018-02-18 19:58 UTC

MorphOneOrMany A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	4
lcom	1
cbo	2
dl	0
loc	41
ccs	11
cts	11
cp	1
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	getMorphValue()	7	2
A	setMorphValue()	4	1
A	initMorphValue()	6	1

<?php

namespace Nip\Records\Relations;

use Nip\Records\Relations\Traits\HasMorphTypeTrait;

/**
 * Class MorphOneOrMany
 * @package Nip\Records\Relations
 */
abstract class MorphOneOrMany extends HasOneOrMany
{
    use HasMorphTypeTrait;

    /**
     * The class name of model manager
     * This value is saved in the morph type collumn
     *
     * @var string
     */
    protected $morphValue = null;

    /**
     * @return string
     */
    public function getMorphValue(): string
    {
        if ($this->morphValue == null) {
            $this->initMorphValue();
        }
        return $this->morphValue;
    }

    /**
     * @param string $morphValue
     */
    public function setMorphValue(string $morphValue)
    {
        $this->morphValue = $morphValue;
    }

    /**
     * @return string
     */
    protected function initMorphValue()
    {
        $this->setMorphValue(
            $this->getManager()->getMorphName()
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        );
    }
}


1		<?php
2
3		namespace Nip\Records\Relations;
4
5		use Nip\Records\Relations\Traits\HasMorphTypeTrait;
6
7		/**
8		* Class MorphOneOrMany
9		* @package Nip\Records\Relations
10		*/
11		abstract class MorphOneOrMany extends HasOneOrMany
12		{
13		use HasMorphTypeTrait;
14
15		/**
16		* The class name of model manager
17		* This value is saved in the morph type collumn
18		*
19		* @var string
20		*/
21		protected $morphValue = null;
22
23		/**
24		* @return string
25		*/
26	2	public function getMorphValue(): string
27		{
28	2	if ($this->morphValue == null) {
29	2	$this->initMorphValue();
30		}
31	2	return $this->morphValue;
32		}
33
34		/**
35		* @param string $morphValue
36		*/
37	2	public function setMorphValue(string $morphValue)
38		{
39	2	$this->morphValue = $morphValue;
40	2	}
41
42		/**
43		* @return string
44		*/
45	2	protected function initMorphValue()
46		{
47	2	$this->setMorphValue(
48	2	$this->getManager()->getMorphName()
		0 ignored issues – show Documentation Bug introduced 2018-02-18 20:02 UTC by Report Bug Copy Issue Report The method `getMorphName` does not exist on `object<Nip\Records\AbstractModels\RecordManager>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
49		);
50	2	}
51		}
52

bytic / orm

Push — master ( c5047e...3a177f )

MorphOneOrMany A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Duplication Side-by-Side

Filter issues like