Nip\Records\Locator\Resolver\Commands\CommandsFactory

Complexity

Total Complexity

6

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

77.78%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	0	8	1
A	createFromAlias()	0	6	1
A	hydrateConfiguration()	0	7	2
A	hydrateModelRegistry()	0	7	2

<?php


namespace Nip\Records\Locator\Resolver\Commands;

use Nip\Records\Locator\Configuration\Configuration;
use Nip\Records\Locator\ModelLocator;
use Nip\Records\Locator\Registry\ModelRegistry;

/**
 * Class CommandsFactory
 * @package Nip\Records\Locator\Resolver\Commands
 */
class CommandsFactory
{

    /**
     * @param string $alias
     * @param ModelLocator $modelLocator
     * @return Command
     */
    public static function create($alias, $modelLocator = null)
    {
        $command = new Command();
        $command->setAlias($alias);
        $command = self::hydrateConfiguration($command, $modelLocator->getConfiguration());

It seems like $modelLocator is not always an object, but can also be of type null. Maybe add an additional type check?

        $command = self::hydrateModelRegistry($command, $modelLocator->getModelRegistry());
        return $command;
    }

    /**
     * @param string $alias
     * @param Configuration|null $configuration
     * @return Command
     */
    public static function createFromAlias($alias, $configuration = null)
    {
        $command = new Command();
        $command->setAlias($alias);
        return self::hydrateConfiguration($command, $configuration);
    }

    /**
     * @param Command $command
     * @param Configuration|null $configuration
     * @return Command
     */
    protected static function hydrateConfiguration(Command $command, $configuration)
    {
        if ($configuration instanceof Configuration) {
            $command->setConfiguration($configuration);
        }
        return $command;
    }

    /**
     * @param Command $command
     * @param ModelRegistry|null $registry
     * @return Command
     */
    protected static function hydrateModelRegistry(Command $command, $registry)
    {
        if ($registry instanceof ModelRegistry) {
            $command->setModelRegistry($registry);
        }
        return $command;
    }
}