Nip\Records\Relations\Traits\HasPrimaryKeyTrait

Complexity

Total Complexity

8

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Test Coverage

Coverage

88.24%

Importance

Changes	1
Bugs	0	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	setPrimaryKey()	0	3	1
A	getPrimaryKey()	0	7	2
A	initPrimaryKey()	0	3	1
A	checkParamPrimaryKey()	0	5	2
A	generatePrimaryKey()	0	3	2

<?php

namespace Nip\Records\Relations\Traits;

use Nip\Records\AbstractModels\RecordManager;

/**
 * Trait HasForeignKeyTrait
 * @package Nip\Records\Relations\Traits
 *
 * @method RecordManager getManager()
 */
trait HasPrimaryKeyTrait
{
    /**
     * @var null|string
     */
    protected $primaryKey = null;

    /**
     * @param $params
     */
    public function checkParamPrimaryKey($params)
    {
        if (isset($params['primaryKey'])) {
            $this->setPrimaryKey($params['primaryKey']);
            unset($params['primaryKey']);
        }
    }

    /**
     * @return string
     */
    public function getPrimaryKey()
    {
        if ($this->primaryKey == null) {

It seems like you are loosely comparing $this->primaryKey of type null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison === instead.

            $this->initPrimaryKey();
        }

        return $this->primaryKey;
    }

    /**
     * @param $name
     */
    public function setPrimaryKey($name)
    {
        $this->primaryKey = $name;
    }

    protected function initPrimaryKey()
    {
        $this->setPrimaryKey($this->generatePrimaryKey());
    }

    /**
     * @return string
     */
    protected function generatePrimaryKey()
    {
        return $this->hasManager() ? $this->getManager()->getPrimaryKey() : 'id';

It seems like hasManager() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }
}