ServerCompletePurchaseRequest::getSoapAction() - Code Metrics - Inspection of "update server complete purchase" - bytic/omnipay-plationline - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( f1b061...8b9c51 )

by Gabriel

created 2020-10-14 10:23 UTC

ServerCompletePurchaseRequest::getSoapAction() A

↳ Parent: ServerCompletePurchaseRequest

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php

namespace ByTIC\Omnipay\PlatiOnline\Message;

use ByTIC\Omnipay\PlatiOnline\Utils\Urls;

/**
 * Class ServerCompletePurchaseRequest
 * @package ByTIC\Omnipay\PlatiOnline\Message
 *
 * @method ServerCompletePurchaseResponse send()
 */
class ServerCompletePurchaseRequest extends AbstractRequest
{
    protected $relayMessageKey = 'f_itsn_message';
    protected $cryptMessageKey = 'f_crypt_message';

    use Traits\RelayRequestTrait;

    use Traits\HasSoapRequestTrait;


    /**
     * @return string
     */
    protected function getSoapAction(): string
    {
        return 'query';
    }

    /**
     * @param \SoapClient $soapClient
     * @param array $data
     */
    protected function runTransaction($soapClient, $data)
    {
        /** @var \SimpleXMLElement $notification */
        $notification = $data['notification'];
        $request['f_website'] = (string)$notification->f_login;

        $request['f_order_number'] = (string)$notification->f_order_number;
        $request['x_trans_id'] = (string)$notification->x_trans_id;
        $request['f_action'] = 0;

        $response = $this->runSoapRequest($soapClient, $request, 'po_query');
        return [
            'notification' => [
                'order' => $response->order,
                'transaction' => $response->order->tranzaction,
                'payment_token' => $response->po_payment_token
            ]
        ];
    }

    protected function getValidationMessageUrl()
    {
        return Urls::$itsnXml;
    }

    protected function getSoapRequestValidationUrl(): string
    {
        return Urls::$queryXml;
    }

    protected function getSoapResponseValidationUrl()
    {
        return Urls::$queryResponseXml;
    }
}


1			<?php
2
3			namespace ByTIC\Omnipay\PlatiOnline\Message;
4
5			use ByTIC\Omnipay\PlatiOnline\Utils\Urls;
6
7			/**
8			* Class ServerCompletePurchaseRequest
9			* @package ByTIC\Omnipay\PlatiOnline\Message
10			*
11			* @method ServerCompletePurchaseResponse send()
12			*/
13			class ServerCompletePurchaseRequest extends AbstractRequest
14			{
15			protected $relayMessageKey = 'f_itsn_message';
16			protected $cryptMessageKey = 'f_crypt_message';
17
18			use Traits\RelayRequestTrait;
			0 ignored issues – show introduced 2020-10-12 06:09 UTC by Report Bug Copy Issue Report The trait `ByTIC\Omnipay\PlatiOnlin...raits\RelayRequestTrait` requires some properties which are not provided by `ByTIC\Omnipay\PlatiOnlin...CompletePurchaseRequest`: `$request`, `$query` Loading history...
19			use Traits\HasSoapRequestTrait;
			0 ignored issues – show Bug introduced 2020-10-14 10:26 UTC by Report Bug Copy Issue Report The trait `ByTIC\Omnipay\PlatiOnlin...its\HasSoapRequestTrait` requires the property `$faultcode` which is not provided by `ByTIC\Omnipay\PlatiOnlin...CompletePurchaseRequest`. Loading history...
20
21			/**
22			* @return string
23			*/
24			protected function getSoapAction(): string
25			{
26			return 'query';
27			}
28
29			/**
30			* @param \SoapClient $soapClient
31			* @param array $data
32			*/
33			protected function runTransaction($soapClient, $data)
34			{
35			/** @var \SimpleXMLElement $notification */
36			$notification = $data['notification'];
37			$request['f_website'] = (string)$notification->f_login;
			0 ignored issues – show Comprehensibility Best Practice introduced 2020-10-14 10:26 UTC by Report Bug Copy Issue Report `$request` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$request = array();` before regardless. Loading history...
38			$request['f_order_number'] = (string)$notification->f_order_number;
39			$request['x_trans_id'] = (string)$notification->x_trans_id;
40			$request['f_action'] = 0;
41
42			$response = $this->runSoapRequest($soapClient, $request, 'po_query');
43			return [
44			'notification' => [
45			'order' => $response->order,
46			'transaction' => $response->order->tranzaction,
47			'payment_token' => $response->po_payment_token
48			]
49			];
50			}
51
52			protected function getValidationMessageUrl()
53			{
54			return Urls::$itsnXml;
55			}
56
57			protected function getSoapRequestValidationUrl(): string
58			{
59			return Urls::$queryXml;
60			}
61
62			protected function getSoapResponseValidationUrl()
63			{
64			return Urls::$queryResponseXml;
65			}
66			}
67

bytic / omnipay-plationline

Push — main ( f1b061...8b9c51 )

ServerCompletePurchaseRequest::getSoapAction() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like