Issues (9)

src/Message/CompletePurchaseResponse.php (1 issue)

Labels
Severity
1
<?php
2
3
namespace Paytic\Omnipay\Paylike\Message;
4
5
use Paytic\Omnipay\Common\Message\Traits\GatewayNotificationResponseTrait;
6
use Paytic\Omnipay\Common\Message\Traits\HtmlResponses\ConfirmHtmlTrait;
7
8
/**
9
 * Class CompletePurchaseResponse
10
 * @package Paytic\Omnipay\Paylike\Message
11
 */
12
class CompletePurchaseResponse extends AbstractResponse
13
{
14
    use ConfirmHtmlTrait;
15
    use GatewayNotificationResponseTrait;
16
17
    /**
18
     * Response Message
19
     *
20
     * @return null|string A response message from the payment gateway
21
     */
22
    public function getMessage()
23
    {
24
        if (!$this->isSuccessful()) {
25
            return 'Error authorising payment';
26
        }
27
28
        return parent::getMessage();
0 ignored issues
show
Are you sure the usage of parent::getMessage() targeting Omnipay\Common\Message\A...tResponse::getMessage() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
29
    }
30
}
31