bytic / omnipay-paylike

src/Message/CompletePurchaseRequest.php

<?php

namespace Paytic\Omnipay\Paylike\Message;

use Paytic\Omnipay\Common\Message\Traits\GatewayNotificationRequestTrait;
use Paytic\Omnipay\Paylike\Traits\HasApiTrait;

/**
 * Class CompletePurchaseRequest
 * @package Paytic\Omnipay\Paylike\Message
 *
 * @method CompletePurchaseResponse send()
 */
class CompletePurchaseRequest extends AbstractRequest
{
    use GatewayNotificationRequestTrait;

The trait Paytic\Omnipay\Common\Message\Traits\GatewayNotificationRequestTrait requires some properties which are not provided by Paytic\Omnipay\Paylike\Message\CompletePurchaseRequest: $query, $request

    use HasApiTrait;

    /**
     * @return mixed
     */
    public function isValidNotification()
    {
        return $this->hasGET('pTransactionId');
    }

    /**
     * @return bool|mixed
     */
    protected function parseNotification()
    {
        $this->validate('privateKey');

        if ($this->isValidTransaction() == false) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            return false;
        }

        $transaction = $this->getDataItem('transaction');

        if ($transaction['pendingAmount'] > 0) {
            $transaction = $this->makeCaptureRequest(
                [
                    'amount' => $transaction['pendingAmount'] / 100,
                    'currency' => $transaction['currency'],
                ]
            );
        }

        return $transaction;
    }

    /**
     * @return bool
     */
    protected function isValidTransaction()
    {
        $transactionId = $this->httpRequest->query->get('pTransactionId');
        $this->setTransactionId($transactionId);

        $isValid = false;
        try {
            $transactions = $this->getApi()->transactions();
            $transaction = $transactions->fetch($transactionId);
            if (is_array($transaction)) {

The condition is_array($transaction) is always true.

                $this->setDataItem('transaction', $transaction);
                $isValid = true;
            }
        } catch (\Paylike\Exception\NotFound $e) {
            $this->setDataItem('message', "The transaction was not found");
        } catch (\Paylike\Exception\ApiException $e) {
            $this->setDataItem('message', "Api Error:" . $e->getMessage());
        }

        if ($isValid) {
            $this->setDataItem('success', true);
        }
        return $isValid;
    }

    /**
     * @param array $parameters
     * @return array
     */
    protected function makeCaptureRequest(array $parameters)
    {
        $request = new CaptureRequest($this->httpClient, $this->httpRequest);
        $request->initialize(array_replace($this->getParameters(), $parameters));
        $response = $request->send();
        return $response->getDataProperty('transaction');
    }
}