Issues in HasMessageBuilderTrait.php (master) - Issues in master - bytic/notifier - Measure and Improve Code Quality continuously with Scrutinizer

Issues (16)

Notifications/HasMessageBuilderTrait.php (1 issue)

Labels

Bug 1

Severity

Minor 1

<?php

namespace ByTIC\Notifications\Notifications;

use ByTIC\Notifications\Messages\Builder\EmailBuilder;

/**
 * Trait HasMessageBuilderTrait
 * @package ByTIC\Notifications\Notifications
 */
trait HasMessageBuilderTrait
{

    /**
     * @param string $type
     * @return mixed
     */
    public function generateMessageBuilder($type = 'mail')
    {
        $class = $this->generateMessageBuilderClass();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $builder = new $class();
        return $builder;
    }

    /**
     * @return string
     */
    public function generateMailBuilderClass()
    {
        return EmailBuilder::class;
    }

    /**
     * @param string $type
     * @return null
     */
    protected function generateMessageBuilderClass($type = 'mail')
    {
        $method = 'generate' . ucfirst($type) . 'BuilderClass';
        if (method_exists($this, $method)) {
            return $this->$method();
        }
        return null;
    }
}


1			<?php
2
3			namespace ByTIC\Notifications\Notifications;
4
5			use ByTIC\Notifications\Messages\Builder\EmailBuilder;
6
7			/**
8			* Trait HasMessageBuilderTrait
9			* @package ByTIC\Notifications\Notifications
10			*/
11			trait HasMessageBuilderTrait
12			{
13
14			/**
15			* @param string $type
16			* @return mixed
17			*/
18			public function generateMessageBuilder($type = 'mail')
19			{
20			$class = $this->generateMessageBuilderClass();
			0 ignored issues – show Bug introduced 2021-11-24 19:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$class` is correct as `$this->generateMessageBuilderClass()` targeting `ByTIC\Notifications\Noti...teMessageBuilderClass()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
21			$builder = new $class();
22			return $builder;
23			}
24
25			/**
26			* @return string
27			*/
28			public function generateMailBuilderClass()
29			{
30			return EmailBuilder::class;
31			}
32
33			/**
34			* @param string $type
35			* @return null
36			*/
37			protected function generateMessageBuilderClass($type = 'mail')
38			{
39			$method = 'generate' . ucfirst($type) . 'BuilderClass';
40			if (method_exists($this, $method)) {
41			return $this->$method();
42			}
43			return null;
44			}
45			}
46

bytic / notifier

Issues (16)

Notifications/HasMessageBuilderTrait.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like