ByTICStrategy::toModel() - Code Metrics - Inspection of "update strategy for model and repository" - bytic/namefy - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( 3feea0...902010 )

by Gabriel

created 2021-03-02 10:42 UTC

ByTICStrategy::toModel() A

↳ Parent: ByTICStrategy

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	1
c	0
b	0
f	0
dl	0
loc	3
rs	10
cc	1
nc	1
nop	1

<?php

namespace ByTIC\Namefy\Strategies;

use ByTIC\Namefy\Name;

/**
 * Class ByTICStrategy
 * @package ByTIC\Namefy\Strategies
 */
class ByTICStrategy extends AbstractStrategy
{
    /**
     * @param $slug
     * @param Name $name
     * @return string
     */
    public function fromRepository($slug, Name $name)
    {
        $slug = $this->cleanModelNamespace($slug);

        return inflector()->unclassify($slug);
    }

    /**
     * @inheritDoc
     */
    public function fromModel($slug, Name $name): string
    {
        $slug = $this->cleanModelNamespace($slug);
        $slug = inflector()->unclassify($slug);
        return inflector()->pluralize($slug);
    }

    public function fromController($slug, Name $name)
    {
        // TODO: Implement fromController() method.
    }

    /**
     * @inheritDoc
     */
    public function toRepository(Name $name): string
    {
        // TODO: Implement toRepository() method.
    }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}

    /**
     * @inheritDoc
     */
    public function toModel(Name $name): string
    {
        return $name;

    }

    /**
     * @inheritDoc
     */
    public function toController(Name $name): string
    {
        return $name->resource();
    }

    protected function cleanModelNamespace($name): string
    {
        if (strpos($name, '\\') === false) {
            return $name;
        }
        if (method_exists($name, 'getRootNamespace')) {
            $name = str_replace((new $name())->getRootNamespace(), '', $name);
        }

        $name = trim($name, '\\');
        $parts = explode('\\', $name);
        array_pop($parts);

        $name = implode('\\', $parts);
        return $name;
    }
}


1			<?php
2
3			namespace ByTIC\Namefy\Strategies;
4
5			use ByTIC\Namefy\Name;
6
7			/**
8			* Class ByTICStrategy
9			* @package ByTIC\Namefy\Strategies
10			*/
11			class ByTICStrategy extends AbstractStrategy
12			{
13			/**
14			* @param $slug
15			* @param Name $name
16			* @return string
17			*/
18			public function fromRepository($slug, Name $name)
19			{
20			$slug = $this->cleanModelNamespace($slug);
21
22			return inflector()->unclassify($slug);
23			}
24
25			/**
26			* @inheritDoc
27			*/
28			public function fromModel($slug, Name $name): string
29			{
30			$slug = $this->cleanModelNamespace($slug);
31			$slug = inflector()->unclassify($slug);
32			return inflector()->pluralize($slug);
33			}
34
35			public function fromController($slug, Name $name)
36			{
37			// TODO: Implement fromController() method.
38			}
39
40			/**
41			* @inheritDoc
42			*/
43			public function toRepository(Name $name): string
44			{
45			// TODO: Implement toRepository() method.
46			}
			0 ignored issues – show Bug Best Practice introduced 2021-03-02 10:57 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `string`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
47
48			/**
49			* @inheritDoc
50			*/
51			public function toModel(Name $name): string
52			{
53			return $name;
			0 ignored issues – show Bug Best Practice introduced 2021-03-02 10:57 UTC by Report Bug Copy Issue Report The expression `return $name` returns the type `ByTIC\Namefy\Name` which is incompatible with the type-hinted return `string`. Loading history...
54			}
55
56			/**
57			* @inheritDoc
58			*/
59			public function toController(Name $name): string
60			{
61			return $name->resource();
62			}
63
64			protected function cleanModelNamespace($name): string
65			{
66			if (strpos($name, '\\') === false) {
67			return $name;
68			}
69			if (method_exists($name, 'getRootNamespace')) {
70			$name = str_replace((new $name())->getRootNamespace(), '', $name);
71			}
72
73			$name = trim($name, '\\');
74			$parts = explode('\\', $name);
75			array_pop($parts);
76
77			$name = implode('\\', $parts);
78			return $name;
79			}
80			}
81

bytic / namefy

Push — main ( 3feea0...902010 )

ByTICStrategy::toModel() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like