SectionDetector::detectFromSubdomain() - Code Metrics - Inspection of "Merge branch 'develop' of https://github.com/bytic..." - bytic/mvc - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( cd9417...6e4265 )

by Gabriel

created 2020-07-15 17:07 UTC

SectionDetector::detectFromSubdomain() A

↳ Parent: SectionDetector

Complexity

Conditions	3
Paths	3

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	3.0416

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	5
nc	3
nop	1
dl	0
loc	10
ccs	5
cts	6
cp	0.8333
crap	3.0416
rs	10
c	1
b	0
f	0

<?php

namespace Nip\Mvc\Sections;

/**
 * Class SectionDetector
 * @package Nip\Mvc\Sections
 */
class SectionDetector
{
    /**
     * @param SectionsCollection $collection
     * @return string
     */
    public static function run($collection)
    {
        $detector = new static();
        return $detector->detect($collection);

    }

    /**
     * @param $collection
     * @return bool|int|mixed|string
     */
    public function detect($collection)
    {
        $current = $this->detectFromConstant();
        if ($current) {

            return $current;
        }
        $current = $this->detectFromSubdomain($collection);
        if ($current) {
            return $current;
        }

        return 'main';
    }

    /**
     * @return bool|string
     */
    protected function detectFromConstant()
    {
        return false;
//        return (defined('SPORTIC_SECTION')) ? SPORTIC_SECTION : false;
    }

    /**
     * @param $collection
     * @return bool|mixed
     */
    protected function detectFromSubdomain($collection)
    {
        $subDomain = $this->getCurrentSubdomain();
        foreach ($collection as $key => $section) {
            if ($subDomain == $section->getSubdomain()) {
                return $key;
            }
        }

        return $subDomain;
    }

    /**
     * @return bool|mixed
     */
    protected function getCurrentSubdomain()
    {
        return request()->getHttp()->getSubdomain();
    }
}


1		<?php
2
3		namespace Nip\Mvc\Sections;
4
5		/**
6		* Class SectionDetector
7		* @package Nip\Mvc\Sections
8		*/
9		class SectionDetector
10		{
11		/**
12		* @param SectionsCollection $collection
13		* @return string
14		*/
15		public static function run($collection)
16		{
17		$detector = new static();
18		return $detector->detect($collection);
		0 ignored issues – show Bug Best Practice introduced 2020-07-15 17:11 UTC by Report Bug Copy Issue Report The expression `return $detector->detect($collection)` also could return the type `boolean` which is incompatible with the documented return type `string`. Loading history...
19		}
20
21		/**
22		* @param $collection
23		* @return bool\|int\|mixed\|string
24		*/
25	1	public function detect($collection)
26		{
27	1	$current = $this->detectFromConstant();
28	1	if ($current) {
		0 ignored issues – show introduced 2020-06-19 12:36 UTC by Report Bug Copy Issue Report The condition `$current` is always `false`. Loading history...
29		return $current;
30		}
31	1	$current = $this->detectFromSubdomain($collection);
32	1	if ($current) {
33	1	return $current;
34		}
35
36		return 'main';
37		}
38
39		/**
40		* @return bool\|string
41		*/
42		protected function detectFromConstant()
43		{
44		return false;
45		// return (defined('SPORTIC_SECTION')) ? SPORTIC_SECTION : false;
46		}
47
48		/**
49		* @param $collection
50		* @return bool\|mixed
51		*/
52	1	protected function detectFromSubdomain($collection)
53		{
54	1	$subDomain = $this->getCurrentSubdomain();
55	1	foreach ($collection as $key => $section) {
56	1	if ($subDomain == $section->getSubdomain()) {
57	1	return $key;
58		}
59		}
60
61		return $subDomain;
62		}
63
64		/**
65		* @return bool\|mixed
66		*/
67		protected function getCurrentSubdomain()
68		{
69		return request()->getHttp()->getSubdomain();
70		}
71		}
72

bytic / mvc

Push — master ( cd9417...6e4265 )

SectionDetector::detectFromSubdomain() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like