Nip\Mvc\Modules\ModulesManager

Complexity

Total Complexity

13

Size/Duplication

Total Lines	82
Duplicated Lines	0 %

Test Coverage

Coverage

44.44%

Importance

Changes	1
Bugs	0	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	loadFromConfig()	0	6	3
A	getViewPath()	0	3	1
A	addModule()	0	4	2
A	getModules()	0	7	2
A	getNames()	0	3	1
A	getModuleDirectory()	0	3	1
A	getModulesBaseDirectory()	0	5	2
A	setModules()	0	3	1

<?php

namespace Nip\Mvc\Modules;

/**
 * Class ModulesManager
 * @package Nip\Mvc\Modules
 */
class ModulesManager
{

    /**
     * @var ModulesCollection
     */
    protected $modules = null;

    /**
     * @return ModulesCollection
     */
    public function getNames()
    {
        return $this->getModules()->all();

The expression return $this->getModules()->all() returns the type array which is incompatible with the documented return type Nip\Mvc\Modules\ModulesCollection.

    }

    /**
     * @param $name
     */
    public function addModule($name)
    {
        if (!$this->getModules()->offsetExists($name)) {
            $this->getModules()->set($name, $name);
        }
    }

    /**
     * @param $name
     *
     * @return string
     */
    public function getViewPath($name)
    {
        return $this->getModuleDirectory($name) . DIRECTORY_SEPARATOR . 'views' . DIRECTORY_SEPARATOR;
    }

    /**
     * @param $name
     *
     * @return string
     */
    public function getModuleDirectory($name)
    {
        return $this->getModulesBaseDirectory() . $name;
    }

    /**
     * @return string
     */
    public function getModulesBaseDirectory()
    {
        return defined('MODULES_PATH') ?
            MODULES_PATH

The constant Nip\Mvc\Modules\MODULES_PATH was not found. Maybe you did not declare it correctly or list all dependencies?

            : app('path') . DIRECTORY_SEPARATOR . 'modules' . DIRECTORY_SEPARATOR;

Are you sure app('path') of type mixed|object can be used in concatenation?

    }

    /**
     * @return ModulesCollection
     */
    public function getModules(): ModulesCollection
    {
        if ($this->modules === null) {
            $this->modules = new ModulesCollection();
            $this->loadFromConfig();
        }
        return $this->modules;
    }

    /**
     * @param ModulesCollection $sections
     */
    public function setModules(ModulesCollection $sections): void
    {
        $this->modules = $sections;
    }

    protected function loadFromConfig()
    {
        if (function_exists('config')) {
            $data = config('mvc.modules', ['admin', 'frontend']);
            foreach ($data as $key => $row) {
                $this->modules->set($key, $row);
            }
        }
    }
}