SectionDetector::detectFromConfig() - Code Metrics - Inspection of "Merge pull request #2 from bytic/analysis-4xP5Kw" - bytic/mvc - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 6ca2b3...f03760 )

by Gabriel

created 2021-11-21 19:52 UTC

SectionDetector::detectFromConfig() A

↳ Parent: SectionDetector

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
ccs	0
cts	0
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php

namespace Nip\Mvc\Sections;

use Nip\Mvc\Utility\PackageConfig;

/**
 * Class SectionDetector
 * @package Nip\Mvc\Sections
 */
class SectionDetector
{
    /**
     * @param SectionsCollection $collection
     * @return string
     */
    public static function run($collection)
    {
        $detector = new static();
        return $detector->detect($collection);

    }

    /**
     * @param $collection
     * @return bool|int|mixed|string
     */
    public function detect($collection)
    {
        $current = $this->detectFromConstant();
        if ($current) {

            return $current;
        }
        $current = $this->detectFromConfig();
        if ($current) {
            return $current;
        }
        $current = $this->detectFromSubdomain($collection);
        if ($current) {
            return $current;
        }

        return 'main';
    }

    /**
     * @return bool|string
     */
    protected function detectFromConfig()
    {
        return PackageConfig::value('defaults.section');
    }

    /**
     * @return bool|string
     */
    protected function detectFromConstant()
    {
        return false;
//        return (defined('SPORTIC_SECTION')) ? SPORTIC_SECTION : false;
    }
    /**
     * @param $collection
     * @return bool|mixed
     */
    protected function detectFromSubdomain($collection)
    {
        $subDomain = $this->getCurrentSubdomain();
        foreach ($collection as $key => $section) {
            if ($subDomain == $section->getSubdomain()) {
                return $key;
            }
        }

        return $subDomain;
    }

    /**
     * @return bool|mixed
     */
    protected function getCurrentSubdomain()
    {
        return request()->getHttp()->getSubdomain();
    }
}


1		<?php
2
3		namespace Nip\Mvc\Sections;
4
5		use Nip\Mvc\Utility\PackageConfig;
6
7		/**
8		* Class SectionDetector
9		* @package Nip\Mvc\Sections
10		*/
11		class SectionDetector
12		{
13		/**
14		* @param SectionsCollection $collection
15		* @return string
16		*/
17		public static function run($collection)
18		{
19		$detector = new static();
20		return $detector->detect($collection);
		0 ignored issues – show Bug Best Practice introduced 2020-07-15 17:11 UTC by Report Bug Copy Issue Report The expression `return $detector->detect($collection)` also could return the type `boolean` which is incompatible with the documented return type `string`. Loading history...
21		}
22
23		/**
24		* @param $collection
25	1	* @return bool\|int\|mixed\|string
26		*/
27	1	public function detect($collection)
28	1	{
29		$current = $this->detectFromConstant();
30		if ($current) {
		0 ignored issues – show introduced 2020-06-19 12:36 UTC by Report Bug Copy Issue Report The condition `$current` is always `false`. Loading history...
31	1	return $current;
32	1	}
33	1	$current = $this->detectFromConfig();
34		if ($current) {
35		return $current;
36		}
37		$current = $this->detectFromSubdomain($collection);
38		if ($current) {
39		return $current;
40		}
41
42		return 'main';
43		}
44
45		/**
46		* @return bool\|string
47		*/
48		protected function detectFromConfig()
49		{
50		return PackageConfig::value('defaults.section');
51		}
52	1
53		/**
54	1	* @return bool\|string
55	1	*/
56	1	protected function detectFromConstant()
57	1	{
58		return false;
59		// return (defined('SPORTIC_SECTION')) ? SPORTIC_SECTION : false;
60		}
61		/**
62		* @param $collection
63		* @return bool\|mixed
64		*/
65		protected function detectFromSubdomain($collection)
66		{
67		$subDomain = $this->getCurrentSubdomain();
68		foreach ($collection as $key => $section) {
69		if ($subDomain == $section->getSubdomain()) {
70		return $key;
71		}
72		}
73
74		return $subDomain;
75		}
76
77		/**
78		* @return bool\|mixed
79		*/
80		protected function getCurrentSubdomain()
81		{
82		return request()->getHttp()->getSubdomain();
83		}
84		}
85

bytic / mvc

Push — master ( 6ca2b3...f03760 )

SectionDetector::detectFromConfig() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like