bytic / money

src/Models/Currencies/CurrenciesTrait.php

<?php

namespace ByTIC\Money\Models\Currencies;

/**
 * trait CurrenciesTrait.
 *
 * @method CurrencyTrait[] getAll()
 * @method CurrencyTrait findByCode($code)
 */
trait CurrenciesTrait
{
    /**
     * @param $from
     * @param $to
     * @param $amount
     *
     * @return float|int
     */
    public function convert($from, $to, $amount)
    {
        $rates['eur'] = '1';

$rates was never initialized. Although not strictly required by PHP, it is generally a good practice to add $rates = array(); before regardless.

        $rates['bgn'] = '0.5113';
        $rates['ron'] = '0.2260';

        return $amount * $rates[$from] / $rates[$to];
    }

    /**
     * @param $code
     *
     * @return CurrencyTrait
     */
    public function getByCode($code)
    {
        return $this->findOne($code);
    }

    /**
     * @param $id
     *
     * @return CurrencyTrait
     */
    abstract public function findOne($id);
}