ByTIC\Money\Models\Currencies\CurrencyTrait

Complexity

Total Complexity

4

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Test Coverage

Coverage

92.86%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	moneyHTMLFormat()	0	20	3
A	getCode()	0	3	1

<?php

namespace ByTIC\Money\Models\Currencies;

/**
 * Trait CurrencyTrait.
 *
 * @property string $code
 * @property string $symbol
 * @property string $position
 */
trait CurrencyTrait
{
    /**
     * @return string
     */
    public function getCode()
    {
        return $this->getAttributeFromArray('code');

It seems like getAttributeFromArray() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param $amount
     *
     * @return string
     */
    public function moneyHTMLFormat($amount)
    {
        $amount = strpos($amount, '.') !== false ? $amount : $amount . '.0';

        list($integerValue, $decimalValue) = explode('.', $amount);
        $intHTML = '<span class="money-int">'.number_format($integerValue).'</span>';

$integerValue of type string is incompatible with the type double expected by parameter $number of number_format().

        $decimalValue = str_pad($decimalValue, 2, '0', STR_PAD_LEFT);
        $decimalHTML = '<sup class="money-decimal">.'.$decimalValue.'</sup>';

        $return = $intHTML.$decimalHTML;

        $symbolHTML = '<span class="money-currency">'.$this->symbol.'</span>';
        if ($this->position == 'before') {
            $return = $symbolHTML.' '.$amount;
        } else {
            $return .= ' '.$symbolHTML;
        }

        return '<span class="price" content="'.$amount.'">'.$return.'</span>';
    }
}