bytic / models-smart-properties

src/Definitions/DefinitionRegistry.php

<?php

namespace ByTIC\Models\SmartProperties\Definitions;

use ByTIC\Models\SmartProperties\Definitions\Builders\RepositoryBuilder;
use Nip\Utility\Traits\SingletonTrait;

/**
 * Class DefinitionRegistry
 * @package ByTIC\Models\SmartProperties\Definitions
 */
class DefinitionRegistry
{
    use SingletonTrait;

    /**
     * @var RepositoryDefinitions[]
     */
    protected array $definitions = [];

    /**
     * @param $manager
     * @param \Closure|null $builder
     * @return RepositoryDefinitions
     */
    public function get($manager, \Closure $builder = null)
    {
        $managerName = $this->managerName($manager);
        if (!isset($this->definitions[$managerName])) {
            $this->definitions[$managerName] = RepositoryBuilder::for($manager, $builder);

It seems like $builder can also be of type null; however, parameter $builder of ByTIC\Models\SmartProperties\Definitions\Builders\RepositoryBuilder::for() does only seem to accept Closure, maybe add an additional type check?

        }
        return $this->definitions[$managerName];
    }

    /**
     * @param object|string $manager
     * @return string
     */
    protected function managerName($manager): string
    {
        if (is_object($manager)) {
            return get_class($manager);
        }
        return (string)$manager;
    }
}