ByTIC\Models\SmartProperties\Properties\Definitions\Traits\HasItemsDirectoryTrait

Complexity

Total Complexity

8

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Test Coverage

Coverage

95%

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	initItemsDirectory()	0	3	1
A	generateItemsDirectory()	0	8	2
A	generatePropertyDirectory()	0	3	1
A	generateManagerDirectory()	0	5	1
A	setItemsDirectory()	0	3	1
A	getItemsDirectory()	0	7	2

<?php

namespace ByTIC\Models\SmartProperties\Properties\Definitions\Traits;

/**
 * Trait HasItemsDirectoryTrait
 * @package ByTIC\Models\SmartProperties\Properties\Definitions\Traits
 */
trait HasItemsDirectoryTrait
{
    protected $itemsDirectory = null;


    /**
     * @return null|string
     */
    public function getItemsDirectory()
    {
        if ($this->itemsDirectory == null) {
            $this->initItemsDirectory();
        }

        return $this->itemsDirectory;
    }

    /**
     * @param $dir
     */
    public function setItemsDirectory($dir)
    {
        $this->itemsDirectory = $dir;
    }

    protected function initItemsDirectory()
    {
        $this->setItemsDirectory($this->generateItemsDirectory());
    }

    /**
     * @return string
     */
    public function generateItemsDirectory()
    {
        $methodName = 'get' . $this->getName() . 'ItemsDirectory';

It seems like getName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if (method_exists($this->getManager(), $methodName)) {

It seems like getManager() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return $this->getManager()->$methodName();
        }

        return $this->generateManagerDirectory() . DIRECTORY_SEPARATOR . $this->generatePropertyDirectory();
    }

    /**
     * @return string
     */
    protected function generateManagerDirectory()
    {
        $reflector = new \ReflectionObject($this->getManager());

        return dirname($reflector->getFileName());
    }

    /**
     * @return string
     */
    protected function generatePropertyDirectory()
    {
        return $this->getLabel();

It seems like getLabel() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }
}