ByTIC\Models\SmartProperties\RecordsTraits\HasTypes\PropertyRecordTrait

Complexity

Total Complexity

6

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Importance

Changes	2
Bugs	1	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getType()	0	3	1
A	setTypeFromObject()	0	5	1
A	setType()	0	4	1
A	updateType()	0	7	2
A	getNewType()	0	4	1

<?php

namespace ByTIC\Models\SmartProperties\RecordsTraits\HasTypes;

use ByTIC\Models\SmartProperties\Properties\Types\Generic as GenericType;

trait PropertyRecordTrait
{
    /**
     * @return \ByTIC\Models\SmartProperties\Properties\AbstractProperty\Generic|GenericType
     */
    public function getType()
    {
        return $this->getSmartProperty('Type');

It seems like getSmartProperty() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param $status
     * @return \ByTIC\Models\SmartProperties\Properties\AbstractProperty\Generic|GenericType
     */
    public function getNewType($status)
    {
        /** @noinspection PhpUnhandledExceptionInspection */
        return $this->getNewSmartPropertyFromValue('Type', $status);

It seems like getNewSmartPropertyFromValue() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param GenericType $type
     * @return bool
     * @throws \Nip\Logger\Exception
     */
    public function updateType($type = null)
    {
        if ($this->setType($type)) {

Are you sure the usage of $this->setType($type) targeting ByTIC\Models\SmartProperties\RecordsTraits\HasTypes\PropertyRecordTrait::setType() seems to always return null.

            $this->update();

The method update() does not exist on ByTIC\Models\SmartProperties\RecordsTraits\HasTypes\PropertyRecordTrait. Did you maybe mean updateType()?

        }

        return false;
    }

    /**
     * @param $value
     */
    public function setType($value)
    {
        /** @noinspection PhpUnhandledExceptionInspection */
        $this->setSmartProperty('Type', $value);

It seems like setSmartProperty() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param $typeObject
     * @return RecordTrait
     */
    public function setTypeFromObject($typeObject)
    {
        /** @noinspection PhpUnhandledExceptionInspection */
        $this->setSmartProperty('Type', $typeObject);
        return $typeObject;
    }
}