ByTIC\Models\SmartProperties\Properties\AbstractProperty\Traits\HasNameTrait

Complexity

Total Complexity

8

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Test Coverage

Coverage

86.67%

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getAliases()	0	3	1
A	generateNameFromClass()	0	11	4
A	getNamespace()	0	3	1
A	setNamespace()	0	3	1
A	generateName()	0	6	1

<?php

namespace ByTIC\Models\SmartProperties\Properties\AbstractProperty\Traits;

use ReflectionClass;

/**
 * Trait HasNameTrait
 * @package ByTIC\Models\SmartProperties\Properties\AbstractProperty\Traits
 */
trait HasNameTrait
{
    protected $namespace = null;

    protected $aliases = [];

    /**
     * @return array
     */
    public function getAliases(): array
    {
        return array_merge($this->aliases, [$this->generateNameFromClass()]);
    }

    /**
     * @return null
     */
    public function getNamespace()
    {
        return $this->namespace;
    }

    /**
     * @param null $namespace

Are you sure the doc-type for parameter $namespace is correct as it would always require null to be passed?

     */
    public function setNamespace($namespace): void
    {
        $this->namespace = $namespace;
    }

    /**
     * @return string
     */
    protected function generateName(): string
    {
        $name = $this->generateNameFromClass();
        $name = inflector()->unclassify($name);

        return $name;
    }

    /**
     * @return string
     */
    protected function generateNameFromClass(): string
    {
        $class = static::class;
        $base = $this->getNamespace();

Are you sure the assignment to $base is correct as $this->getNamespace() targeting ByTIC\Models\SmartProperties\Properties\AbstractProperty\Traits\HasNameTrait::getNamespace() seems to always return null.

        if ($base && strpos($class, $base) ===0) {

$base of type void is incompatible with the type string expected by parameter $needle of strpos().

$base is of type null, thus it always evaluated to false.

            return str_replace($base, '', $class);
        }
        try {
            return (new ReflectionClass($this))->getShortName();
        } catch (\ReflectionException $e) {
            return '';
        }
    }
}