HasParamsTrait::mergeParams() - Code Metrics - Inspection of "add convert path to array if string" - bytic/migrations - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 472b4c...8e27d6 )

by Gabriel

created 2020-08-11 14:58 UTC

HasParamsTrait::mergeParams() A

↳ Parent: HasParamsTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	3
ccs	2
cts	2
cp	1
crap	1
rs	10
c	1
b	0
f	0

<?php

namespace ByTIC\Migrations\Config\Traits;

/**
 * Trait HasParamsTrait
 * @package ByTIC\Migrations\Config\Traits
 */
trait HasParamsTrait
{
    protected $params = [];

    /**
     * @return null
     */
    public function getParams()
    {
        return $this->params;

    }

    /**
     * @param null $params

     */
    public function setParams($params)
    {
        $this->params = $params;
    }

    /**
     * @param $params
     */
    public function mergeParams($params)
    {
        $this->params = array_merge($this->params, $params);
    }

    /**
     * @return array
     */
    public function toArray()
    {
        return $this->params;
    }

    protected function generateBaseParams()
    {
        $this->params = [
            'paths' => [
                'migrations' => [],
                'seeds' => [],
            ],
            'environments' => [],
        ];
    }
}

1		<?php
2
3		namespace ByTIC\Migrations\Config\Traits;
4
5		/**
6		* Trait HasParamsTrait
7		* @package ByTIC\Migrations\Config\Traits
8		*/
9		trait HasParamsTrait
10		{
11		protected $params = [];
12
13		/**
14		* @return null
15		*/
16		public function getParams()
17		{
18		return $this->params;
		0 ignored issues – show Bug Best Practice introduced 2020-08-11 15:02 UTC by Report Bug Copy Issue Report The expression `return $this->params` returns the type `array` which is incompatible with the documented return type `null`. Loading history...
19		}
20
21		/**
22		* @param null $params
		0 ignored issues – show Documentation Bug introduced 2020-08-11 15:02 UTC by Report Bug Copy Issue Report Are you sure the doc-type for parameter `$params` is correct as it would always require `null` to be passed? Loading history...
23		*/
24	1	public function setParams($params)
25		{
26	1	$this->params = $params;
27	1	}
28
29		/**
30		* @param $params
31		*/
32	2	public function mergeParams($params)
33		{
34	2	$this->params = array_merge($this->params, $params);
35	2	}
36
37		/**
38		* @return array
39		*/
40	5	public function toArray()
41		{
42	5	return $this->params;
43		}
44
45	8	protected function generateBaseParams()
46		{
47	8	$this->params = [
48		'paths' => [
49		'migrations' => [],
50		'seeds' => [],
51		],
52		'environments' => [],
53		];
54		}
55		}

bytic / migrations

Push — master ( 472b4c...8e27d6 )

HasParamsTrait::mergeParams() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like