Nip\Mail\Traits\MailableTrait

Complexity

Total Complexity

5

Size/Duplication

Total Lines	98
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

12.5%

Importance

Changes

0

12 Methods

Rating	Name	Duplication	Size	Complexity
A	send()	0	11	1
A	buildMailMessage()	0	13	1
A	beforeSend()	0	3	1
A	afterSend()	0	3	1
	buildMailMessageFrom()	0	1	?
	buildMailMessageRecipients()	0	1	?
	buildMailMessageSubject()	0	1	?
	buildMailMessageBody()	0	1	?
	buildMailMessageAttachments()	0	1	?
	buildMailMessageMergeTags()	0	1	?
	buildMailMessageCustomArgs()	0	1	?
A	newMailMessage()	0	6	1

<?php

namespace Nip\Mail\Traits;

use Nip\Mail\Mailer;
use Nip\Mail\Message;

/**
 * Class MailableTrait
 * @package Nip\Mail\Traits
 */
trait MailableTrait
{
    use MailerAwareTrait;

    /**
     * @return int
     */
    public function send()
    {
        $mailer = $this->getMailer();
        $message = $this->buildMailMessage();

        $this->beforeSend($mailer, $message);

It seems like $mailer defined by $this->getMailer() on line 21 can be null; however, Nip\Mail\Traits\MailableTrait::beforeSend() does not accept null, maybe add an additional type check?

        $recipients = $mailer->send($message);
        $this->afterSend($mailer, $message, $recipients);

It seems like $mailer defined by $this->getMailer() on line 21 can be null; however, Nip\Mail\Traits\MailableTrait::afterSend() does not accept null, maybe add an additional type check?

        return $recipients;
    }

    /**
     * @return Message
     */
    public function buildMailMessage()
    {
        $message = $this->newMailMessage();
        $this->buildMailMessageFrom($message);
        $this->buildMailMessageRecipients($message);
        $this->buildMailMessageSubject($message);
        $this->buildMailMessageBody($message);
        $this->buildMailMessageAttachments($message);
        $this->buildMailMessageMergeTags($message);
        $this->buildMailMessageCustomArgs($message);

        return $message;
    }

    /**
     * @return Message
     */
    public function newMailMessage()
    {
        $message = new Message();

        return $message;
    }

    /**
     * @param Mailer $mailer
     * @param Message $message
     */
    protected function beforeSend($mailer, $message)

The parameter $mailer is not used and could be removed.

The parameter $message is not used and could be removed.

    {
    }

    /**
     * @param Mailer $mailer
     * @param Message $message
     * @param int $recipients
     */
    protected function afterSend($mailer, $message, $recipients)

The parameter $mailer is not used and could be removed.

The parameter $message is not used and could be removed.

The parameter $recipients is not used and could be removed.

    {
    }

    /**
     * @param Message $message
     */
    abstract public function buildMailMessageFrom(&$message);

    /**
     * @param Message $message
     */
    abstract public function buildMailMessageRecipients(&$message);

    /**
     * @param Message $message
     */
    abstract public function buildMailMessageSubject(&$message);

    /**
     * @param Message $message
     */
    abstract public function buildMailMessageBody(&$message);

    /**
     * @param Message $message
     */
    abstract public function buildMailMessageAttachments(&$message);

    /**
     * @param Message $message
     */
    abstract public function buildMailMessageMergeTags(&$message);

    /**
     * @param Message $message
     */
    abstract public function buildMailMessageCustomArgs(&$message);
}