Nip\Locale\Traits\HasSupportedTrait

Complexity

Total Complexity

6

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Test Coverage

Coverage

83.33%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	isSupported()	0	3	1
A	getSupported()	0	15	5

<?php

namespace Nip\Locale\Traits;

use DirectoryIterator;

/**
 * Trait HasSupportedTrait
 * @package Nip\Locale\Traits
 */
trait HasSupportedTrait
{
    protected $supported;

    public function getSupported()
    {
        if (!$this->supported) {
            $iterator = new DirectoryIterator($this->getDataFolder());

It seems like getDataFolder() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            foreach ($iterator as $file) {
                if ($file->isFile()) {
                    $fileName = $file->getFilename();
                    if (substr($fileName, 0, 1) != '_') {
                        $name = str_replace('.php', '', $fileName);
                        $this->supported[] = $name;
                    }
                }
            }
        }
        return $this->supported;
    }

    /**
     * @param $name
     * @return bool
     */
    public function isSupported($name)
    {
        return $this->hasDataFile($name);

It seems like hasDataFile() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }
}