Issues in MagicMethodsTrait.php - New Issues - Inspection of "Merge branch 'develop'" - bytic/inflector - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 03087a...f49b8e )

by Gabriel

created 2018-02-09 20:40 UTC

src/Traits/MagicMethodsTrait.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Nip\Inflector\Traits;

use Nip\Inflector\Inflector;

/**
 * Trait MagicMethodsTrait
 * @package Nip\Inflector\Traits
 */
trait MagicMethodsTrait
{

    /**
     * @param $name
     * @param $arguments
     * @return string
     */
    public function __call($name, $arguments)
    {
        if ($this->hasInflection($name)) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            return $this->doInflection($name, $arguments[0]);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        }
        throw new \BadFunctionCallException("invalid inflection {$name}");
    }

    /**
     * @param $name
     * @param $arguments
     * @return mixed
     */
    public static function __callStatic($name, $arguments)
    {
        return (new Inflector())->doInflection($name, $arguments[0]);
    }
}


1		<?php
2
3		namespace Nip\Inflector\Traits;
4
5		use Nip\Inflector\Inflector;
6
7		/**
8		* Trait MagicMethodsTrait
9		* @package Nip\Inflector\Traits
10		*/
11		trait MagicMethodsTrait
12		{
13
14		/**
15		* @param $name
16		* @param $arguments
17		* @return string
18		*/
19	19	public function __call($name, $arguments)
20		{
21	19	if ($this->hasInflection($name)) {
		0 ignored issues – show Documentation Bug introduced 2018-02-09 20:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `hasInflection` does not exist on `object<Nip\Inflector\Traits\MagicMethodsTrait>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
22	19	return $this->doInflection($name, $arguments[0]);
		0 ignored issues – show Documentation Bug introduced 2018-02-09 20:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `doInflection` does not exist on `object<Nip\Inflector\Traits\MagicMethodsTrait>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
23		}
24		throw new \BadFunctionCallException("invalid inflection {$name}");
25		}
26
27		/**
28		* @param $name
29		* @param $arguments
30		* @return mixed
31		*/
32		public static function __callStatic($name, $arguments)
33		{
34		return (new Inflector())->doInflection($name, $arguments[0]);
35		}
36		}
37

bytic / inflector

Push — master ( 03087a...f49b8e )

src/Traits/MagicMethodsTrait.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like