Issues in InflectionTableizeTrait.php - New Issues - Inspection of "Merge branch 'develop'" - bytic/inflector - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 03087a...f49b8e )

by Gabriel

created 2018-02-09 20:40 UTC

src/Traits/InflectionTableizeTrait.php (2 issues)

Labels

Bug 2

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Nip\Inflector\Traits;

/**
 * Trait InflectionTableizeTrait
 * @package Nip\Inflector\Traits
 *
 * @method tableize($string)
 */
trait InflectionTableizeTrait
{

    /**
     * Converts a class name to its table name according to rails
     * naming conventions.
     *
     * Converts "Person" to "people"
     *
     * @param string $class_name Class name for getting related table_name.
     * @return string plural_table_name
     */
    protected function doTableize($class_name)
    {
        return $this->pluralize($this->underscore($class_name));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			namespace Nip\Inflector\Traits;
4
5			/**
6			* Trait InflectionTableizeTrait
7			* @package Nip\Inflector\Traits
8			*
9			* @method tableize($string)
10			*/
11			trait InflectionTableizeTrait
12			{
13
14			/**
15			* Converts a class name to its table name according to rails
16			* naming conventions.
17			*
18			* Converts "Person" to "people"
19			*
20			* @param string $class_name Class name for getting related table_name.
21			* @return string plural_table_name
22			*/
23			protected function doTableize($class_name)
24			{
25			return $this->pluralize($this->underscore($class_name));
			0 ignored issues – show Bug introduced 2018-02-09 20:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `underscore()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2018-02-09 20:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `pluralize()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
26			}
27			}
28

bytic / inflector

Push — master ( 03087a...f49b8e )

src/Traits/InflectionTableizeTrait.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like