bytic / http

src/Kernel/Traits/HandleExceptions.php

<?php

namespace Nip\Http\Kernel\Traits;

use Exception;
use Nip\Http\Exceptions\Handler;
use Nip\Http\Response\Response;
use Nip\Request;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Throwable;

/**
 * Trait HandleExceptions
 * @package Nip\Http\Kernel\Traits
 */
trait HandleExceptions
{
    /**
     * Report the exception to the exception handler.
     *
     * @param Exception $e
     * @return void
     */
    protected function reportException(Throwable $e)
    {
        app('log')->error($e);
    }

    /**
     * @param Request|ServerRequestInterface $request
     * @param Exception $e
     * @return Response|ResponseInterface
     */
    protected function renderException($request, Throwable $e)
    {
        return (new Handler($this->getContainer()))->render($request, $e);

It seems like getContainer() must be provided by classes using this trait. How about adding it as abstract method to this trait?

The expression return new Nip\Http\Exceptions\Handler($this->getContainer())->render($request, $e) returns the type Symfony\Component\HttpFoundation\JsonResponse which is incompatible with the documented return type Nip\Http\Response\Response|Psr\Http\Message\ResponseInterface.

    }

    /**
     * @param Exception $e
     * @param Request|ServerRequestInterface $request
     * @return Response
     */
    protected function handleException($request, Throwable $e)
    {
        $this->reportException($e);

        return $this->renderException($request, $e);
    }
}