HttpTest::getBaseUrlData() - Code Metrics - Inspection of "update interacts with input" - bytic/http - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d129c8...00172d )

by Gabriel

created 2020-05-12 13:40 UTC

HttpTest::getBaseUrlData() A

↳ Parent: HttpTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	72
Code Lines	43

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	43
c	0
b	0
f	0
nc	1
nop	0
dl	0
loc	72
rs	9.232

How to fix Long Method

<?php

/**
 * From Symfony Symfony\Component\HttpFoundation\Tests\HttpTest class
 */

namespace Nip\Http\Tests\Request;

use Nip\Http\Tests\AbstractTest;
use Nip\Request;

/**
 * Class HttpTest
 * @package Nip\Tests\Request
 */
class HttpTest extends AbstractTest
{
    /**
     * @var \UnitTester
filter:
    dependency_paths: ["lib/*"]
     */
    protected $tester;

    /**
     * @dataProvider getBaseUrlData
     */
    public function testGetBaseUrl($uri, $server, $expectedBaseUrl, $expectedPathInfo)
    {
        $request = Request::create($uri, 'GET', [], [], [], $server);
        static::assertSame($expectedBaseUrl, $request->getHttp()->getBaseUrl(), 'baseUrl');
        static::assertSame($expectedPathInfo, $request->getPathInfo(), 'pathInfo');
    }

    // tests

    /**
     * @return array
     */
    public function getBaseUrlData()
    {
        return [
            [
                '/fruit/strawberry/1234index.php/blah',
                [
                    'SCRIPT_FILENAME' => 'E:/Sites/cc-new/public_html/fruit/index.php',
                    'SCRIPT_NAME' => '/fruit/index.php',
                    'PHP_SELF' => '/fruit/index.php',
                ],
                '/fruit',
                '/strawberry/1234index.php/blah',
            ],
            [
                '/fruit/strawberry/1234index.php/blah',
                [
                    'SCRIPT_FILENAME' => 'E:/Sites/cc-new/public_html/index.php',
                    'SCRIPT_NAME' => '/index.php',
                    'PHP_SELF' => '/index.php',
                ],
                '',
                '/fruit/strawberry/1234index.php/blah',
            ],
            [
                '/foo%20bar/',
                [
                    'SCRIPT_FILENAME' => '/home/John Doe/public_html/foo bar/app.php',
                    'SCRIPT_NAME' => '/foo bar/app.php',
                    'PHP_SELF' => '/foo bar/app.php',
                ],
                '/foo%20bar',
                '/',
            ],
            [
                '/foo%20bar/home',
                [
                    'SCRIPT_FILENAME' => '/home/John Doe/public_html/foo bar/app.php',
                    'SCRIPT_NAME' => '/foo bar/app.php',
                    'PHP_SELF' => '/foo bar/app.php',
                ],
                '/foo%20bar',
                '/home',
            ],
            [
                '/foo%20bar/app.php/home',
                [
                    'SCRIPT_FILENAME' => '/home/John Doe/public_html/foo bar/app.php',
                    'SCRIPT_NAME' => '/foo bar/app.php',
                    'PHP_SELF' => '/foo bar/app.php',
                ],
                '/foo%20bar/app.php',
                '/home',
            ],
            [
                '/foo%20bar/app.php/home%3Dbaz',
                [
                    'SCRIPT_FILENAME' => '/home/John Doe/public_html/foo bar/app.php',
                    'SCRIPT_NAME' => '/foo bar/app.php',
                    'PHP_SELF' => '/foo bar/app.php',
                ],
                '/foo%20bar/app.php',
                '/home%3Dbaz',
            ],
            [
                '/foo/bar+baz',
                [
                    'SCRIPT_FILENAME' => '/home/John Doe/public_html/foo/app.php',
                    'SCRIPT_NAME' => '/foo/app.php',
                    'PHP_SELF' => '/foo/app.php',
                ],
                '/foo',
                '/bar+baz',
            ],
        ];
    }

    public function testGetUri()
    {
        $request = Request::create('http://test.com/foo?bar=baz');
        static::assertEquals('http://test.com/foo?bar=baz', $request->getHttp()->getUri());
    }
}


1			<?php
2
3			/**
4			* From Symfony Symfony\Component\HttpFoundation\Tests\HttpTest class
5			*/
6
7			namespace Nip\Http\Tests\Request;
8
9			use Nip\Http\Tests\AbstractTest;
10			use Nip\Request;
11
12			/**
13			* Class HttpTest
14			* @package Nip\Tests\Request
15			*/
16			class HttpTest extends AbstractTest
17			{
18			/**
19			* @var \UnitTester
			0 ignored issues – show Bug introduced 2020-05-12 13:43 UTC by Report Bug Copy Issue Report The type `UnitTester` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
20			*/
21			protected $tester;
22
23			/**
24			* @dataProvider getBaseUrlData
25			*/
26			public function testGetBaseUrl($uri, $server, $expectedBaseUrl, $expectedPathInfo)
27			{
28			$request = Request::create($uri, 'GET', [], [], [], $server);
29			static::assertSame($expectedBaseUrl, $request->getHttp()->getBaseUrl(), 'baseUrl');
30			static::assertSame($expectedPathInfo, $request->getPathInfo(), 'pathInfo');
31			}
32
33			// tests
34
35			/**
36			* @return array
37			*/
38			public function getBaseUrlData()
39			{
40			return [
41			[
42			'/fruit/strawberry/1234index.php/blah',
43			[
44			'SCRIPT_FILENAME' => 'E:/Sites/cc-new/public_html/fruit/index.php',
45			'SCRIPT_NAME' => '/fruit/index.php',
46			'PHP_SELF' => '/fruit/index.php',
47			],
48			'/fruit',
49			'/strawberry/1234index.php/blah',
50			],
51			[
52			'/fruit/strawberry/1234index.php/blah',
53			[
54			'SCRIPT_FILENAME' => 'E:/Sites/cc-new/public_html/index.php',
55			'SCRIPT_NAME' => '/index.php',
56			'PHP_SELF' => '/index.php',
57			],
58			'',
59			'/fruit/strawberry/1234index.php/blah',
60			],
61			[
62			'/foo%20bar/',
63			[
64			'SCRIPT_FILENAME' => '/home/John Doe/public_html/foo bar/app.php',
65			'SCRIPT_NAME' => '/foo bar/app.php',
66			'PHP_SELF' => '/foo bar/app.php',
67			],
68			'/foo%20bar',
69			'/',
70			],
71			[
72			'/foo%20bar/home',
73			[
74			'SCRIPT_FILENAME' => '/home/John Doe/public_html/foo bar/app.php',
75			'SCRIPT_NAME' => '/foo bar/app.php',
76			'PHP_SELF' => '/foo bar/app.php',
77			],
78			'/foo%20bar',
79			'/home',
80			],
81			[
82			'/foo%20bar/app.php/home',
83			[
84			'SCRIPT_FILENAME' => '/home/John Doe/public_html/foo bar/app.php',
85			'SCRIPT_NAME' => '/foo bar/app.php',
86			'PHP_SELF' => '/foo bar/app.php',
87			],
88			'/foo%20bar/app.php',
89			'/home',
90			],
91			[
92			'/foo%20bar/app.php/home%3Dbaz',
93			[
94			'SCRIPT_FILENAME' => '/home/John Doe/public_html/foo bar/app.php',
95			'SCRIPT_NAME' => '/foo bar/app.php',
96			'PHP_SELF' => '/foo bar/app.php',
97			],
98			'/foo%20bar/app.php',
99			'/home%3Dbaz',
100			],
101			[
102			'/foo/bar+baz',
103			[
104			'SCRIPT_FILENAME' => '/home/John Doe/public_html/foo/app.php',
105			'SCRIPT_NAME' => '/foo/app.php',
106			'PHP_SELF' => '/foo/app.php',
107			],
108			'/foo',
109			'/bar+baz',
110			],
111			];
112			}
113
114			public function testGetUri()
115			{
116			$request = Request::create('http://test.com/foo?bar=baz');
117			static::assertEquals('http://test.com/foo?bar=baz', $request->getHttp()->getUri());
118			}
119			}
120

bytic / http

Push — master ( d129c8...00172d )

HttpTest::getBaseUrlData() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like