Nip\Http\Request\Traits\ArrayAccessTrait

Complexity

Total Complexity

5

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Test Coverage

Coverage

33.33%

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	offsetExists()	0	3	1
A	__get()	0	3	1
A	offsetSet()	0	3	1
A	offsetGet()	0	3	1
A	offsetUnset()	0	3	1

<?php

namespace Nip\Http\Request\Traits;

/**
 * Class ArrayAccessTrait
 * @package Nip\Http\Request\Traits
 */
trait ArrayAccessTrait
{
    /**
     * @param mixed $offset
     * @return bool
     */
    public function offsetExists($offset)
    {
        return $this->has($offset);

It seems like has() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param mixed $offset
     * @return mixed
     */
    public function offsetGet($offset)
    {
        return $this->get($offset);

It seems like get() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param mixed $offset
     * @param mixed $value
     */
    public function offsetSet($offset, $value)
    {
        $this->attributes->set($offset, $value);

The property attributes does not exist on Nip\Http\Request\Traits\ArrayAccessTrait. Since you implemented __get, consider adding a @property annotation.

    }

    /**
     * @param mixed $offset
     */
    public function offsetUnset($offset)
    {
        $this->attributes->remove($offset);

The property attributes does not exist on Nip\Http\Request\Traits\ArrayAccessTrait. Since you implemented __get, consider adding a @property annotation.

    }

    /**
     * @param $name
     * @return mixed
     */
    public function __get($name)
    {
        return $this->get($name);
    }
}