KeysControllerTest::testIndex() - Code Metrics - Inspection of "fix get user_id from token data" - bytic/hello - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( a6b51e...5fffdb )

by Gabriel

created 2019-03-31 11:54 UTC

KeysControllerTest::testIndex() A

↳ Parent: KeysControllerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	14
rs	9.7998
c	0
b	0
f	0

<?php

namespace ByTIC\Hello\Tests\Modules\Oauth\Controllers;

use ByTIC\Hello\Modules\Oauth\Controllers\KeysController;
use ByTIC\Hello\Tests\AbstractTest;
use ByTIC\Hello\Utility\CryptHelper;
use Nip\Container\Container;
use Nip\Http\Response\JsonResponse;

/**
 * Class KeysControllerTest
 * @package ByTIC\Hello\Tests\Modules\Oauth\Controllers
 */
class KeysControllerTest extends AbstractTest
{
    public function testIndex()
    {
        $container = new Container();
        $container->set('hello.keys.public', CryptHelper::makeCryptKey('public'));
        Container::setInstance($container);

        $controller = new KeysController();
        /** @var JsonResponse $response */
        $response = $controller->callAction('index');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        self::assertInstanceOf(JsonResponse::class, $response);
        $content = $response->getContent();
        self::assertJson($content);
    }
}


1			<?php
2
3			namespace ByTIC\Hello\Tests\Modules\Oauth\Controllers;
4
5			use ByTIC\Hello\Modules\Oauth\Controllers\KeysController;
6			use ByTIC\Hello\Tests\AbstractTest;
7			use ByTIC\Hello\Utility\CryptHelper;
8			use Nip\Container\Container;
9			use Nip\Http\Response\JsonResponse;
10
11			/**
12			* Class KeysControllerTest
13			* @package ByTIC\Hello\Tests\Modules\Oauth\Controllers
14			*/
15			class KeysControllerTest extends AbstractTest
16			{
17			public function testIndex()
18			{
19			$container = new Container();
20			$container->set('hello.keys.public', CryptHelper::makeCryptKey('public'));
21			Container::setInstance($container);
22
23			$controller = new KeysController();
24			/** @var JsonResponse $response */
25			$response = $controller->callAction('index');
			0 ignored issues – show Documentation introduced 2019-03-31 12:02 UTC by Report Bug Copy Issue Report `'index'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
26
27			self::assertInstanceOf(JsonResponse::class, $response);
28			$content = $response->getContent();
29			self::assertJson($content);
30			}
31			}
32

bytic / hello

Push — master ( a6b51e...5fffdb )

KeysControllerTest::testIndex() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like