PersonalAccessGrant::respondToAccessTokenRequest() - Code Metrics - Inspection of "fix get user_id from token data" - bytic/hello - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( a6b51e...5fffdb )

by Gabriel

created 2019-03-31 11:54 UTC

PersonalAccessGrant::respondToAccessTokenRequest() A

↳ Parent: PersonalAccessGrant

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
nc	1
nop	3
dl	0
loc	23
rs	9.552
c	0
b	0
f	0
ccs	0
cts	11
cp	0
crap	2

<?php

namespace ByTIC\Hello\Oauth\Grants;

use DateInterval;
use Psr\Http\Message\ServerRequestInterface;
use League\OAuth2\Server\Grant\AbstractGrant;
use League\OAuth2\Server\ResponseTypes\ResponseTypeInterface;

/**
 * Class PersonalAccessGrant
 * @package ByTIC\Hello\Oauth\Grants
 */
class PersonalAccessGrant extends AbstractGrant
{
    /**
     * {@inheritdoc}
     */
    public function respondToAccessTokenRequest(
        ServerRequestInterface $request,
        ResponseTypeInterface $responseType,
        DateInterval $accessTokenTTL
    ) {
        // Validate request
        $client = $this->validateClient($request);
        $scopes = $this->validateScopes($this->getRequestParameter('scope', $request));

        // Finalize the requested scopes
        $scopes = $this->scopeRepository->finalizeScopes($scopes, $this->getIdentifier(), $client);

        // Issue and persist access token
        $accessToken = $this->issueAccessToken(
            $accessTokenTTL,
            $client,
            $this->getRequestParameter('user_id', $request),
            $scopes
        );
        // Inject access token into response type
        $responseType->setAccessToken($accessToken);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
        return $responseType;
    }

    /**
     * {@inheritdoc}
     */
    public function getIdentifier()
    {
        return 'personal_access';
    }
}


1			<?php
2
3			namespace ByTIC\Hello\Oauth\Grants;
4
5			use DateInterval;
6			use Psr\Http\Message\ServerRequestInterface;
7			use League\OAuth2\Server\Grant\AbstractGrant;
8			use League\OAuth2\Server\ResponseTypes\ResponseTypeInterface;
9
10			/**
11			* Class PersonalAccessGrant
12			* @package ByTIC\Hello\Oauth\Grants
13			*/
14			class PersonalAccessGrant extends AbstractGrant
15			{
16			/**
17			* {@inheritdoc}
18			*/
19			public function respondToAccessTokenRequest(
20			ServerRequestInterface $request,
21			ResponseTypeInterface $responseType,
22			DateInterval $accessTokenTTL
23			) {
24			// Validate request
25			$client = $this->validateClient($request);
26			$scopes = $this->validateScopes($this->getRequestParameter('scope', $request));
27
28			// Finalize the requested scopes
29			$scopes = $this->scopeRepository->finalizeScopes($scopes, $this->getIdentifier(), $client);
30
31			// Issue and persist access token
32			$accessToken = $this->issueAccessToken(
33			$accessTokenTTL,
34			$client,
35			$this->getRequestParameter('user_id', $request),
36			$scopes
37			);
38			// Inject access token into response type
39			$responseType->setAccessToken($accessToken);
			0 ignored issues – show Bug introduced 2019-03-31 12:02 UTC by Report Bug Copy Issue Report It seems like `$accessToken` defined by `$this->issueAccessToken(...d', $request), $scopes)` on line `32` can be `null`; however, `League\OAuth2\Server\Res...rface::setAccessToken()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
40			return $responseType;
41			}
42
43			/**
44			* {@inheritdoc}
45			*/
46			public function getIdentifier()
47			{
48			return 'personal_access';
49			}
50			}
51

bytic / hello

Push — master ( a6b51e...5fffdb )

PersonalAccessGrant::respondToAccessTokenRequest() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like