TokenFactory::findAccessToken() - Code Metrics - Inspection of "fix get user_id from token data" - bytic/hello - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( a6b51e...5fffdb )

by Gabriel

created 2019-03-31 11:54 UTC

TokenFactory::findAccessToken() A

↳ Parent: TokenFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
nc	1
nop	1
dl	0
loc	6
rs	10
c	0
b	0
f	0
ccs	0
cts	3
cp	0
crap	2

<?php

namespace ByTIC\Hello\Models\Clients\PersonalAccess;

use ByTIC\Hello\Models\AccessTokens\Token;
use ByTIC\Hello\Models\Clients\Client;
use ByTIC\Hello\Utility\ModelsHelper;
use Firebase\JWT\JWT;
use League\OAuth2\Server\AuthorizationServer;
use Lcobucci\JWT\Parser as JwtParser;
use Nip\Container\Container;
use Zend\Diactoros\ServerRequest;
use Zend\Diactoros\Response;

/**
 * Class TokenFactory
 * @package ByTIC\Hello\Models\Clients\PersonalAccess
 */
class TokenFactory
{

    /**
     * The authorization server instance.
     *
     * @var \League\OAuth2\Server\AuthorizationServer
     */
    protected $server;

    /**
     * @var Client
     */
    protected $client;

    /**
     * @var Client
     */
    protected $jwt;

    /**
     * TokenFactory constructor
     *
     * @param \League\OAuth2\Server\AuthorizationServer $server
     * @param $client
     */
    public function __construct(AuthorizationServer $server = null, $client = null, JwtParser $jwt = null)
    {
        $this->server = $server ? $server : Container::getInstance()->get(AuthorizationServer::class);
        $this->client = $client ? $client : ClientsManager::get();
        $this->jwt = $jwt ? $jwt : new JwtParser();

    }


    /**
     * Create a new personal access token.
     *a
     * @param mixed $userId
     * @param string $name
     * @param array $scopes
     * @return \Laravel\Passport\PersonalAccessTokenResult
     */
    public function make($userId, $name, array $scopes = [])

    {
        $response = $this->dispatchRequestToAuthorizationServer(
            $this->createRequest($this->client, $userId, $scopes)
        );

        $token = $this->findAccessToken($response);

        return $token;
    }

    /**
     * Create a request instance for the given client.
     *
     * @param Client $client
     * @param mixed $userId
     * @param array $scopes
     * @return Request
     */
    protected function createRequest($client, $userId, array $scopes)
    {
        return (new ServerRequest())->withParsedBody([
            'grant_type' => 'personal_access',
            'client_id' => $client->getIdentifier(),
            'client_secret' => $client->getSecret(),
            'user_id' => $userId,
            'scope' => implode(' ', $scopes),
        ]);
    }

    /**
     * Dispatch the given request to the authorization server.
     *
     * @param Request $request
     * @return array
     */
    protected function dispatchRequestToAuthorizationServer(ServerRequest $request)
    {
        return json_decode(
            $this->server->respondToAccessTokenRequest(
                $request, new Response
            )->getBody()->__toString(),
            true
        );
    }

    /**
     * Get the access token instance for the parsed response.
     *
     * @param array $response
     * @return Token
     */
    protected function findAccessToken(array $response)
    {
        return ModelsHelper::accessTokens()->getByIdentifier(
            $this->jwt->parse($response['access_token'])->getClaim('jti')
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        );
    }
}


1		<?php
2
3		namespace ByTIC\Hello\Models\Clients\PersonalAccess;
4
5		use ByTIC\Hello\Models\AccessTokens\Token;
6		use ByTIC\Hello\Models\Clients\Client;
7		use ByTIC\Hello\Utility\ModelsHelper;
8		use Firebase\JWT\JWT;
9		use League\OAuth2\Server\AuthorizationServer;
10		use Lcobucci\JWT\Parser as JwtParser;
11		use Nip\Container\Container;
12		use Zend\Diactoros\ServerRequest;
13		use Zend\Diactoros\Response;
14
15		/**
16		* Class TokenFactory
17		* @package ByTIC\Hello\Models\Clients\PersonalAccess
18		*/
19		class TokenFactory
20		{
21
22		/**
23		* The authorization server instance.
24		*
25		* @var \League\OAuth2\Server\AuthorizationServer
26		*/
27		protected $server;
28
29		/**
30		* @var Client
31		*/
32		protected $client;
33
34		/**
35		* @var Client
36		*/
37		protected $jwt;
38
39		/**
40		* TokenFactory constructor
41		*
42		* @param \League\OAuth2\Server\AuthorizationServer $server
43		* @param $client
44		*/
45	1	public function __construct(AuthorizationServer $server = null, $client = null, JwtParser $jwt = null)
46		{
47	1	$this->server = $server ? $server : Container::getInstance()->get(AuthorizationServer::class);
48	1	$this->client = $client ? $client : ClientsManager::get();
49	1	$this->jwt = $jwt ? $jwt : new JwtParser();
		0 ignored issues – show Documentation Bug introduced 2019-03-31 12:02 UTC by Report Bug Copy Issue Report It seems like `$jwt ? $jwt : new \Lcobucci\JWT\Parser()` of type `object<Lcobucci\JWT\Parser>` is incompatible with the declared type `object<ByTIC\Hello\Models\Clients\Client>` of property `$jwt`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
50	1	}
51
52
53		/**
54		* Create a new personal access token.
55		*a
56		* @param mixed $userId
57		* @param string $name
58		* @param array $scopes
59		* @return \Laravel\Passport\PersonalAccessTokenResult
60		*/
61	1	public function make($userId, $name, array $scopes = [])
		0 ignored issues – show Unused Code introduced 2019-03-31 12:02 UTC by Report Bug Copy Issue Report The parameter `$name` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
62		{
63	1	$response = $this->dispatchRequestToAuthorizationServer(
64	1	$this->createRequest($this->client, $userId, $scopes)
65		);
66
67	1	$token = $this->findAccessToken($response);
68
69	1	return $token;
70		}
71
72		/**
73		* Create a request instance for the given client.
74		*
75		* @param Client $client
76		* @param mixed $userId
77		* @param array $scopes
78		* @return Request
79		*/
80	1	protected function createRequest($client, $userId, array $scopes)
81		{
82	1	return (new ServerRequest())->withParsedBody([
83	1	'grant_type' => 'personal_access',
84	1	'client_id' => $client->getIdentifier(),
85	1	'client_secret' => $client->getSecret(),
86	1	'user_id' => $userId,
87	1	'scope' => implode(' ', $scopes),
88		]);
89		}
90
91		/**
92		* Dispatch the given request to the authorization server.
93		*
94		* @param Request $request
95		* @return array
96		*/
97	1	protected function dispatchRequestToAuthorizationServer(ServerRequest $request)
98		{
99	1	return json_decode(
100	1	$this->server->respondToAccessTokenRequest(
101	1	$request, new Response
102	1	)->getBody()->__toString(),
103	1	true
104		);
105		}
106
107		/**
108		* Get the access token instance for the parsed response.
109		*
110		* @param array $response
111		* @return Token
112		*/
113		protected function findAccessToken(array $response)
114		{
115		return ModelsHelper::accessTokens()->getByIdentifier(
116		$this->jwt->parse($response['access_token'])->getClaim('jti')
		0 ignored issues – show Documentation Bug introduced 2019-03-31 12:02 UTC by Report Bug Copy Issue Report The method `parse` does not exist on `object<ByTIC\Hello\Models\Clients\Client>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
117		);
118		}
119		}
120

bytic / hello

Push — master ( a6b51e...5fffdb )

TokenFactory::findAccessToken() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like