ClientTest - Code Metrics - Inspection of "fix get user_id from token data" - bytic/hello - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( a6b51e...5fffdb )

by Gabriel

created 2019-03-31 11:54 UTC

ClientTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	29
Duplicated Lines	51.72 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

Metric	Value
dl	15
loc	29
rs	10
c	0
b	0
f	0
wmc	2
lcom	1
cbo	5

2 Methods

Rating	Name	Duplication	Size	Complexity
A	testInitIdentifierFromDB()	0	9	1
A	testSetIdentifier()	15	15	1

How to fix Duplicated Code

<?php

namespace ByTIC\Hello\Tests\Models\Clients;

use ByTIC\Hello\Models\Clients\Client;
use ByTIC\Hello\Models\Clients\Clients;
use ByTIC\Hello\Tests\AbstractTest;

/**
 * Class ClientTest
 * @package ByTIC\Hello\Tests\Models\Clients
 */
class ClientTest extends AbstractTest
{

    public function testInitIdentifierFromDB()
    {
        $client = new Client();
        $client->writeData(['id' => 9, 'identifier' => '']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        self::assertGreaterThan('10', $client->getIdentifier());

        $client->writeData(['id' => 9, 'identifier' => '9999']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        self::assertSame('9999', $client->getIdentifier());
    }

    public function testSetIdentifier()

    {
        /** @var Clients $clients */
        $clients = \Mockery::mock(Clients::class)->makePartial();
        $clients->shouldReceive('getFields')->andReturn(['id', 'identifier', 'secret']);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $clients->shouldReceive('getPrimaryKey')->andReturn('id');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $clients->shouldReceive('getModel')->andReturn(Client::class);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        $client = $clients->getNew();
        $identifier = $client->getIdentifier();
        self::assertGreaterThan(30, strlen($identifier));

        $data = $clients->getQueryModelData($client);
        self::assertArrayHasKey('identifier', $data);
    }
}


1		<?php
2
3		namespace ByTIC\Hello\Tests\Models\Clients;
4
5		use ByTIC\Hello\Models\Clients\Client;
6		use ByTIC\Hello\Models\Clients\Clients;
7		use ByTIC\Hello\Tests\AbstractTest;
8
9		/**
10		* Class ClientTest
11		* @package ByTIC\Hello\Tests\Models\Clients
12		*/
13		class ClientTest extends AbstractTest
14		{
15
16		public function testInitIdentifierFromDB()
17		{
18		$client = new Client();
19		$client->writeData(['id' => 9, 'identifier' => '']);
		0 ignored issues – show Documentation introduced 2019-03-31 12:02 UTC by Report Bug Copy Issue Report `array('id' => 9, 'identifier' => '')` is of type `array<string,integer\|str..."identifier":"string"}>`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
20		self::assertGreaterThan('10', $client->getIdentifier());
21
22		$client->writeData(['id' => 9, 'identifier' => '9999']);
		0 ignored issues – show Documentation introduced 2019-03-31 12:02 UTC by Report Bug Copy Issue Report `array('id' => 9, 'identifier' => '9999')` is of type `array<string,integer\|str..."identifier":"string"}>`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
23		self::assertSame('9999', $client->getIdentifier());
24		}
25
26	View Code Duplication	public function testSetIdentifier()
		0 ignored issues – show Duplication introduced 2019-03-31 12:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
27		{
28		/** @var Clients $clients */
29		$clients = \Mockery::mock(Clients::class)->makePartial();
30		$clients->shouldReceive('getFields')->andReturn(['id', 'identifier', 'secret']);
		0 ignored issues – show Documentation Bug introduced 2019-03-31 12:02 UTC by Report Bug Copy Issue Report The method `shouldReceive` does not exist on `object<ByTIC\Hello\Models\Clients\Clients>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
31		$clients->shouldReceive('getPrimaryKey')->andReturn('id');
		0 ignored issues – show Documentation Bug introduced 2019-03-31 12:02 UTC by Report Bug Copy Issue Report The method `shouldReceive` does not exist on `object<ByTIC\Hello\Models\Clients\Clients>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
32		$clients->shouldReceive('getModel')->andReturn(Client::class);
		0 ignored issues – show Documentation Bug introduced 2019-03-31 12:02 UTC by Report Bug Copy Issue Report The method `shouldReceive` does not exist on `object<ByTIC\Hello\Models\Clients\Clients>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
33
34		$client = $clients->getNew();
35		$identifier = $client->getIdentifier();
36		self::assertGreaterThan(30, strlen($identifier));
37
38		$data = $clients->getQueryModelData($client);
39		self::assertArrayHasKey('identifier', $data);
40		}
41		}
42

bytic / hello

Push — master ( a6b51e...5fffdb )

ClientTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like