ByTIC\Hello\Modules\AbstractModule\Controllers\Traits\AbstractAuthenticationControllerTrait

Complexity

Total Complexity

13

Size/Duplication

Total Lines	85
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	beforeAction()	0	5	1
A	afterActionViewVariables()	0	6	1
A	checkIsAuthenticated()	0	6	3
A	doSuccessRedirect()	0	10	2
A	getRedirectURL()	0	11	3
A	getGenericRedirectURL()	0	5	1
A	_setMeta()	0	8	1
A	generateModelName()	0	4	1

<?php

namespace ByTIC\Hello\Modules\AbstractModule\Controllers\Traits;

/**
 * Trait AbstractAuthenticationControllerTrait
 * @package ByTIC\Hello\Modules\AbstractModule\Controllers\Traits
 */
trait AbstractAuthenticationControllerTrait
{
    use HasAuthenticationVariablesTrait;

    protected function beforeAction()
    {
        parent::beforeAction();
        $this->checkIsAuthenticated();
    }

    protected function afterActionViewVariables()
    {
        parent::afterActionViewVariables();

        $this->setAuthenticationVariablesInView();
    }

    /**
     * @param null $type

There is no parameter named $type. Was it maybe removed?

     */
    protected function checkIsAuthenticated()
    {
        if ($this->getName() != 'logout' && $this->_getUser()->authenticated()) {

It seems like getName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

It seems like _getUser() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $this->doSuccessRedirect();
        }
    }

    /**
     * @param null $type
     */
    protected function doSuccessRedirect($type = null)
    {
        $type = empty($type) ? $this->getName() : $type;

It seems like getName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->flashRedirect(
            $this->getModelManager()->getMessage($type . '-success'),
            $this->getRedirectURL(),
            'success',
            'index'

'index' is of type string, but the function expects a boolean.

        );
    }

    /**
     * @return string
     */
    protected function getRedirectURL()
    {
        $redirectVariable = $this->getAuthenticationValue('redirect');
        if (!empty($redirectVariable)) {
            $url = urldecode($redirectVariable);
            if (valid_url($url)) {
                return $url;
            }
        }
        return $this->getGenericRedirectURL();
    }

    /**
     * @return string|null
     */
    protected function getGenericRedirectURL()
    {
        $module = $this->getRequest()->getModuleName();
        return $this->Url()->assemble($module . '.logged_in');

It seems like Url() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param $action
     */
    protected function _setMeta($action)
    {
        $label = $this->getModelManager()->getLabel($action . '-title');
        $urlMethod = 'get' . ucfirst($action) . 'URL';
        $this->getView()->Breadcrumbs()->addItem($label, $this->_getUser()->getManager()->$urlMethod());

It seems like _getUser() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->getView()->Meta()->prependTitle($label);
    }

    /**
     * @inheritdoc
     */
    protected function generateModelName()
    {
        return get_class($this->_getUser()->getManager());

It seems like _getUser() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }
}