ByTIC\Hello\Oauth\ServiceProvider\Traits\GrantsTrait

Complexity

Total Complexity

13

Size/Duplication

Total Lines	107
Duplicated Lines	0 %

Test Coverage

Coverage

14.29%

Importance

Changes	1
Bugs	0	Features	1

9 Methods

Rating	Name	Duplication	Size	Complexity
A	makeGrantAuthCode()	0	9	1
A	makeGrant()	0	6	4
A	makeGrantClientCredentials()	0	3	1
A	getRegisteredGrants()	0	3	1
A	makeGrantImplicit()	0	4	1
A	makeGrantRefreshToken()	0	4	1
A	makeGrantPersonalAccess()	0	7	1
A	registerGrants()	0	6	2
A	makeGrantPassword()	0	5	1

<?php

namespace ByTIC\Hello\Oauth\ServiceProvider\Traits;

use ByTIC\Hello\Utility\ConfigHelper;
use DateInterval;
use League\OAuth2\Server\AuthorizationServer;
use League\OAuth2\Server\Repositories\AuthCodeRepositoryInterface;
use League\OAuth2\Server\Repositories\RefreshTokenRepositoryInterface;
use League\OAuth2\Server\Repositories\UserRepositoryInterface;

/**
 * Trait GrantsTrait
 * @package ByTIC\Hello\Oauth\ServiceProvider\Traits
 */
trait GrantsTrait
{
    /**
     * @param AuthorizationServer $server
     */
    public function registerGrants(AuthorizationServer $server)
    {
        $grantTypes = $this->getRegisteredGrants();
        foreach ($grantTypes as $type => $class) {
            $method = 'makeGrant' . $type;
            $this->{$method}($server, $class);
        }
    }

    /**
     * @return mixed|\Nip\Config\Config
     */
    protected function getRegisteredGrants()
    {
        return ConfigHelper::get('grant_types', []);
    }

    /**
     * @param AuthorizationServer $server
     * @param string $class
     */
    protected function makeGrantPersonalAccess(AuthorizationServer $server, string $class)
    {
        $this->makeGrant(
            $server,
            $class,
            [],
            new DateInterval('P1Y')
        );
    }

    /**
     * @param AuthorizationServer $server
     * @param string $class
     */
    protected function makeGrantAuthCode(AuthorizationServer $server, string $class)
    {
        $this->makeGrant(
            $server,
            $class,
            [
                $this->getContainer()->get(AuthCodeRepositoryInterface::class),

It seems like getContainer() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                $this->getContainer()->get(RefreshTokenRepositoryInterface::class),
                ConfigHelper::get('token_ttl')
            ]
        );
    }

    /**
     * @param AuthorizationServer $server
     * @param string $class
     */
    protected function makeGrantRefreshToken(AuthorizationServer $server, string $class)
    {
        $this->makeGrant($server, $class, [
            $this->getContainer()->get(RefreshTokenRepositoryInterface::class)
        ]);
    }

    /**
     * @param AuthorizationServer $server
     * @param string $class
     */
    protected function makeGrantPassword(AuthorizationServer $server, string $class)
    {
        $this->makeGrant($server, $class, [
            $this->getContainer()->get(UserRepositoryInterface::class),
            $this->getContainer()->get(RefreshTokenRepositoryInterface::class)
        ]);
    }

    /**
     * @param AuthorizationServer $server
     * @param string $class
     */
    protected function makeGrantImplicit(AuthorizationServer $server, string $class)
    {
        $this->makeGrant($server, $class, [
            ConfigHelper::get('token_ttl')
        ]);
    }

    /**
     * @param AuthorizationServer $server
     * @param string $class
     */
    protected function makeGrantClientCredentials(AuthorizationServer $server, string $class)
    {
        $this->makeGrant($server, $class, []);
    }

    /**
     * @param AuthorizationServer $server
     * @param string|null $type
     * @param array $args
     */
    protected function makeGrant(AuthorizationServer $server, string $type, array $args, $accessTokenTTL = null)
    {
        if ($type !== null) {

The condition $type !== null is always true.

            $grant = new $type(...$args);
            if ($type !== null && $grant !== null) {
                $server->enableGrantType($grant, $accessTokenTTL);
            }
        }
    }
}